Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom integrations in Analytics Insights #109110

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

joostlek
Copy link
Member

Proposed change

Add support for custom integrations in Analytics Insights

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 3606978 into home-assistant:dev Jan 30, 2024
23 checks passed
@joostlek joostlek deleted the haai-custom branch January 30, 2024 16:52
@codyc1515
Copy link
Contributor

codyc1515 commented Jan 30, 2024

What is the intent around this? I think I understand but we should call this out clearly in the next release notes so that people understand what information may be shared (there could be private integrations in there). Is this sharing just integrations from HACS or even user created ones?

@frenck
Copy link
Member

frenck commented Jan 30, 2024

@codyc1515 It is data from our public analytics. https://analytics.home-assistant.io.

What it tracks and how it works is well documented.

../Frenck

@codyc1515
Copy link
Contributor

codyc1515 commented Jan 30, 2024

So, it looks to me now like we said that we would capture custom integrations previously, but we weren't actually doing that till now? No issue then in that case and pleasing to see.

@frenck
Copy link
Member

frenck commented Jan 31, 2024

I think the documentation is clear about it:

"The names and versions of all your custom integrations if you have any"

https://www.home-assistant.io/integrations/analytics

but we weren't actually doing that till now?

This did not change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants