-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom integrations in Analytics Insights #109110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @joostlek 👍
../Frenck
What is the intent around this? I think I understand but we should call this out clearly in the next release notes so that people understand what information may be shared (there could be private integrations in there). Is this sharing just integrations from HACS or even user created ones? |
@codyc1515 It is data from our public analytics. https://analytics.home-assistant.io. What it tracks and how it works is well documented. ../Frenck |
So, it looks to me now like we said that we would capture custom integrations previously, but we weren't actually doing that till now? No issue then in that case and pleasing to see. |
I think the documentation is clear about it:
https://www.home-assistant.io/integrations/analytics
This did not change. |
Updates references to Analytics integrations to match with home-assistant/core#109110 using the tests in https://github.com/home-assistant/core/blob/fcfacaaabdcd80d1700f874edc81de725a79060d/tests/components/analytics_insights/test_config_flow.py#L107-L108
Proposed change
Add support for custom integrations in Analytics Insights
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: