Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update analytics.markdown to match core PR 109110 #31155

Closed
wants to merge 1 commit into from

Conversation

codyc1515
Copy link
Contributor

@codyc1515 codyc1515 commented Jan 31, 2024

Proposed change

Updates references to Analytics integrations to match with home-assistant/core#109110 using the tests in https://github.com/home-assistant/core/blob/dev/tests/components/analytics_insights/test_config_flow.py#L107-L108 (as opposed to placeholders).

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@codyc1515 codyc1515 requested review from ludeeus and a team as code owners January 31, 2024 00:05
@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Jan 31, 2024
@home-assistant
Copy link

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@codyc1515
Copy link
Contributor Author

Rebase not required as functionality is already current (per documentation) according to frenck

@frenck
Copy link
Member

frenck commented Jan 31, 2024

This documentation is not of the insights integration.

Going to close it, as this change is unneeded and unrelated to linked PR.

../Frenck

@frenck frenck closed this Jan 31, 2024
@home-assistant home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Jan 31, 2024
@codyc1515 codyc1515 deleted the patch-1 branch January 31, 2024 01:13
@codyc1515
Copy link
Contributor Author

Ah, sorry, it is the inverse of what I thought.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants