-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new intents for cover, valve, vacuum, and media player #110757
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
In the future I may see a place for a VacuumPause too. Even if it is far less used than starting and returning them to base. It's really low priority. For example, my vacuum starts by cleaning right next to the entry door, making it inaccessible. I always found it weird that lights spans accros two "domains" (Hass and Light). So I would propose specific domain to be able to extend it later on I also think that, using the same reasoning about why you pick "Unpause" instead of "Play", calling it ReturnToBase is much clearer than TurnOff that could be confused with a Stop. |
You said that setting a media player volume is between 0 and 1. Can we make sure that at least by voice it's between 0 and 100? |
Yep, I just updated hassil specifically so we could so this 😄 |
INTENT_MEDIA_PAUSE = "HassMediaPause" | ||
INTENT_MEDIA_UNPAUSE = "HassMediaUnpause" | ||
INTENT_MEDIA_NEXT = "HassMediaNext" | ||
INTENT_SET_VOLUME = "HassSetVolume" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This service made me wonder … how will we respond if the specified entity does not support the set volume service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm...we may want to consider an "unsupported feature" error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already raise that error from service helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just would need to translate it for voice
Breaking change
Proposed change
Adds several new intents and enhances some existing intents for different integrations:
HassTurnOn
andHassTurnOff
HassSetPosition
(new)HassSetVolume
(new)HassMediaPause
(new)HassMediaUnpause
(new)HassMediaNext
(new)HassVacuumStart
(new)HassVacuumReturnToBase
(new)Points of Discussion
Intents are an abstraction above service calls that represent common ways of interacting with devices/entities, and therefore do not need to exactly match the underlying service call nomenclature. However, deviating too much may cause confusion, so there must be a reasonable balance.
Media Unpause
Why not
HassMediaPlay
instead ofHassMediaUnpause
? To make it very clear that the intent does not take a media URI to play. In this case, I have purposefully avoided the confusing service call nomenclature ofmedia_player.media_play
vsmedia_player.play_media
.Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: