Support time entities in time conditions #124575
Conversation
|
Frontend PR is still the original and approved: home-assistant/frontend#21069 |
| try: | ||
| after = datetime.strptime(after_entity.state, "%H:%M:%S").time() | ||
| except ValueError: | ||
| return False |
There was a problem hiding this comment.
Why do we return False here? When does a time entity have a state which can't be parsed?
Should we instead check the state is not in (unavailable, unknown) as for timestamp sensors; if it is return False, and if the state can't be parsed raise ConditionError?
There was a problem hiding this comment.
It's to let the unit test pass:
hass.states.async_set("time.invalid_timestamp", "This is not a timestamp")
If the state becomes invalid, I don't think we should raise?
There was a problem hiding this comment.
Right, but calling hass.states.async_set with a value the time entity can't have in a test is not a good test IMO.
Based on the time entity's implementation, its state can be:
unavailableif the time entity's available property isFalseunknownif the the time entity'snative_valueisNone- a valid time string
|
Converting to draft as there seem to be open comments |
Proposed change
Allow the new time entities introduced in 2023.6 to be used in automation 'time' conditions, just like input_datetime helpers and sensors with timestamp device class.
This PR builds further on the closed PR #119428.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: