-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain time entity support in time condition #33217
base: next
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThis update introduces the ability to reference a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant TimeEntity
participant ConditionChecker
User->>Script: Define condition with `before` option using a `time` entity.
Script->>TimeEntity: Retrieve time value.
TimeEntity-->>Script: Return time value.
Script->>ConditionChecker: Evaluate condition using retrieved time.
ConditionChecker-->>Script: Condition result.
Script-->>User: Return condition evaluation result.
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional context usedLanguageTool
Markdownlint
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
@@ -563,7 +563,7 @@ A better weekday condition could be by using the [Workday Binary Sensor](/integr | |||
|
|||
</div> | |||
|
|||
For the `after` and `before` options a time helper (`input_datetime` entity) | |||
For the `after` and `before` options a time helper (`input_datetime` entity), a `time` entity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the usage of time
entity in the after
and before
options.
The addition of a time
entity alongside input_datetime
and other sensors is a significant enhancement. It would be beneficial to include a brief explanation or link to further documentation on how a time
entity differs from input_datetime
and other timestamp-containing sensors, especially for new users.
Tools
LanguageTool
[misspelling] ~566-~566: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...erand
beforeoptions a time helper (
input_datetimeentity), a
time` entity, or another ...
Markdownlint
566-566: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
Proposed change
Updating the documentation for a new feature to support time entities in automation conditions.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
time
entity in thebefore
option in the conditions script.time
entity in the conditions script.