Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-cloud-pubsub to 2.9.0 (attempt #2) #63522

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Jan 5, 2022

Proposed change

Try again PR #63493 to kick off grpcio wheel build.

This should not be merged until #63521 which sets flags to build grpcio from source with all the required link flags.

Once this runs, we'll watch the actions to ensure grpcio is built correctly.

Original PR description:

The primary motivation is to kick off building wheels for grpcio, however there are also many pub/sub related bug fixes since 2.1.0 in September 2020.

googleapis/python-pubsub@v2.1.0...v2.9.0 where notable changes include Graceful streaming pull shutdown (desired by nest and should help with #63206) and flow control improvements.

This also implicitly pulls in GRPC, which has been behind since Aug 2020.
grpc/grpc@v1.31.0...v1.43.0

I've manually tested this with:

  • Publisher client: Tested via google_pubsub
  • Subscriber client: Tested via nest
  • I've been using latest versions of grpcio for local development testing of google-nest-sdm for the past year

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Try again PR home-assistant#63493 to kick off grpcio wheel build.

This should not be merged until home-assistant#63521 which sets flags to build grpcio from source with all the required link flags.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright! Here she goes (the PR that is)! 👍

@frenck frenck merged commit 1baa3d8 into home-assistant:dev Jan 6, 2022
allenporter added a commit that referenced this pull request Jan 6, 2022
allenporter added a commit that referenced this pull request Jan 6, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants