-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dual IP stack support to HomeKit #94126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
by-code-owner
Quality Scale: No score
Quality Scale: internal
labels
Jun 6, 2023
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bdraco
commented
Jun 6, 2023
bdraco
commented
Jun 6, 2023
fixes pairing with newer iOS changelog: ikalchev/HAP-python@v4.6.0...4.7.0
20 tasks
8 tasks
frenck
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Jun 21, 2023
Merging in dev to retest to make sure everything still working ok with other recent changes |
Retest is good |
CI was flaking. merged in again |
balloob
approved these changes
Jun 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
has-tests
integration: homekit
Quality Scale: No score
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
needs ikalchev/HAP-python#442needs #94812needs #94816HomeKit now announces all IPs configured by the network integration which matches the same behavior we use to announce Home Assistant itself in the zeroconf integration.
This should fix a whole lot of users with multiple interfaces / IPv6. I did not mark specific issues because so many of the issues in the queue are network issues and its not possible to know which ones this will resolve without knowing users network layouts.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: