Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing multiple ip to advertise on to AccessoryDriver #442

Merged
merged 6 commits into from
Jun 17, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Jun 6, 2023

needed for ipv6 support / dual stack home-assistant/core#94126

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #442 (57e1f35) into dev (8b62c19) will increase coverage by 0.03%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##              dev     #442      +/-   ##
==========================================
+ Coverage   91.63%   91.67%   +0.03%     
==========================================
  Files          20       20              
  Lines        2140     2149       +9     
  Branches      264      266       +2     
==========================================
+ Hits         1961     1970       +9     
  Misses        136      136              
  Partials       43       43              
Impacted Files Coverage Δ
pyhap/accessory_driver.py 91.66% <83.33%> (ø)
pyhap/state.py 100.00% <100.00%> (ø)
pyhap/util.py 100.00% <100.00%> (ø)

@bdraco bdraco marked this pull request as ready for review June 6, 2023 17:37
@ikalchev ikalchev merged commit 0552b91 into ikalchev:dev Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants