Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain time entity support in time condition #33217

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Explain time entity support in time condition #33217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion source/_docs/scripts/conditions.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ A better weekday condition could be by using the [Workday Binary Sensor](/integr

</div>

For the `after` and `before` options a time helper (`input_datetime` entity)
For the `after` and `before` options a time helper (`input_datetime` entity), a `time` entity,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify the usage of time entity in the after and before options.

The addition of a time entity alongside input_datetime and other sensors is a significant enhancement. It would be beneficial to include a brief explanation or link to further documentation on how a time entity differs from input_datetime and other timestamp-containing sensors, especially for new users.

Tools
LanguageTool

[misspelling] ~566-~566: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...erandbefore options a time helper (input_datetimeentity), atime` entity, or another ...

Markdownlint

566-566: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces

or another `sensor` entity containing a timestamp with the "timestamp" device
class, can be used instead.

Expand All @@ -574,6 +574,9 @@ condition:
after: input_datetime.house_silent_hours_start
before: input_datetime.house_silent_hours_end

- alias: "Example referencing a time entity"
before: time.dnd_start

- alias: "Example referencing another sensor"
after: sensor.groceries_delivery_time
```
Expand Down