Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HU] Correction of responses. #1905

Merged
merged 23 commits into from
Feb 1, 2024
Merged

[HU] Correction of responses. #1905

merged 23 commits into from
Feb 1, 2024

Conversation

v1k70rk4
Copy link
Member

Corrected: Incorrect conjugations in the responses
Embedding of the pull request #778

v1k70rk4 and others added 23 commits January 14, 2024 02:18
The current intentions are unusable, as they do not employ conjugations at any level. The entire language, which utilizes conjugations, has been updated.

Due to the nature of the Hungarian language, there's an issue where word roots change with conjugation. (For example, if the room is a kitchen, instead of "kapcsold be az összes ventilátort a konyhaban", it should be "konyhában".)

I circumvented these with suffix words, like using "piros színre" instead of "pirosra", or by changing the word order to avoid these issues. This way, it works, like "kapcsold be a konyha összes ventilátorát is."

But for correct and complete Hungarian expressions, it's advisable to use assistant aliases for room names whose endings change with conjugation, such as "szoba" (room), "konyha" (kitchen). For these, "szobá" and "konyhá" aliases should be added.
with this, the Hungarian translation became 100%

Added the [in here] feature:
cover_HassTurnOff
cover_HassTurnOn
light_HassLightSet
light_HassTurnOff
light_HassTurnOn
fan_HassTurnOff
fan_HassTurnOn

New:
sensor_HassGetState
More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.
More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.
More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.
bugfix
due to the free word order, different suffixes are also needed.
…r message.

Thank you to the contributors of ticket home-assistant#1895. This way, I learned that error messages can be processed :) Following the French model, the Hungarian error messages have now become completely Hungarian. + it also handles the articles of words.

+optimization in the Todo/Shopping list, I reduced the number of variations with the specified suffixes.
…mber format

I have corrected the responses to put the correct article in front of the word.
The number format correction involves changing 12.1 to 12,1 and replacing "-" with the word "minus".

And an attempt to find out what cover states the live system returns in the live environment. If it's English, then from now on it should also display it in Hungarian; if it's not English, then everything remains as it was.
@nagyrobi nagyrobi merged commit 205d708 into home-assistant:main Feb 1, 2024
2 checks passed
@v1k70rk4 v1k70rk4 mentioned this pull request Feb 1, 2024
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
* Updating Hungarian intentions

The current intentions are unusable, as they do not employ conjugations at any level. The entire language, which utilizes conjugations, has been updated.

Due to the nature of the Hungarian language, there's an issue where word roots change with conjugation. (For example, if the room is a kitchen, instead of "kapcsold be az összes ventilátort a konyhaban", it should be "konyhában".)

I circumvented these with suffix words, like using "piros színre" instead of "pirosra", or by changing the word order to avoid these issues. This way, it works, like "kapcsold be a konyha összes ventilátorát is."

But for correct and complete Hungarian expressions, it's advisable to use assistant aliases for room names whose endings change with conjugation, such as "szoba" (room), "konyha" (kitchen). For these, "szobá" and "konyhá" aliases should be added.

* Updating Hungarian intentions rev2

* [HU] Added the sensor_HassGetState and the 'in_here' function

with this, the Hungarian translation became 100%

Added the [in here] feature:
cover_HassTurnOff
cover_HassTurnOn
light_HassLightSet
light_HassTurnOff
light_HassTurnOn
fan_HassTurnOff
fan_HassTurnOn

New:
sensor_HassGetState

* [HU] Added the sensor_HassGetState and the 'in_here' function v2

* [hu] More flexible word order, bug fix, +2 color

More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.

* [hu] More flexible word order, bug fix, +2 color

More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.

* [hu] More flexible word order, bug fix, +2 color

More flexible word order, especially for lighting
+2 color translations
a minor bug fix
more readable code.

* [hu] bugfix

bugfix
due to the free word order, different suffixes are also needed.

* [hu] bugfix

* bugfix v2

* [HU] Translation of error messages + handling of articles in the error message.

Thank you to the contributors of ticket home-assistant#1895. This way, I learned that error messages can be processed :) Following the French model, the Hungarian error messages have now become completely Hungarian. + it also handles the articles of words.

+optimization in the Todo/Shopping list, I reduced the number of variations with the specified suffixes.

* [HU] Optimization of response, handling of articles, correction of number format

I have corrected the responses to put the correct article in front of the word.
The number format correction involves changing 12.1 to 12,1 and replacing "-" with the word "minus".

And an attempt to find out what cover states the live system returns in the live environment. If it's English, then from now on it should also display it in Hungarian; if it's not English, then everything remains as it was.

* [HU] Correction of responses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants