Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI] Update latest Vietnamese intents up to March 02, 2024 #2023

Merged
merged 21 commits into from
Mar 4, 2024

Conversation

dinhchinh82
Copy link
Contributor

  • Update all the new intents up to March 02, 2024

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dinhchinh82,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@home-assistant
Copy link

home-assistant bot commented Mar 2, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 2, 2024 12:03
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dinhchinh82,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dinhchinh82,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dinhchinh82,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <[email protected]>"
      
      (substituting "Author Name" and "[email protected]" for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

* [UK] Add new intents for cover, valve, vacuum, media player (home-assistant#1978)

* [UK] Add new intents for cover, valve, vacuum, media player

* Fixed fixtures

* [DE] Add new intents for cover, valve, vacuum, media player (home-assistant#1970)

* [DE] Implement additions from home-assistant#1970 (home-assistant#1991)

* [CS] Add sentence for turning on/off lights in the satelite area. Added expansion rule for lights in plural/singular (home-assistant#1995)

* added turn on all lights

* fix tests

* add expansion for plural or singular lights

* [RU] add intents for media_player (home-assistant#1994)

* [RO] Fixes and improvements (home-assistant#1989)

* Fix spacing in _common.yaml

* binary_sensor

* Climate

* Cover

* Fan

* homeassistant domain

* Light

* Lock

* Media player

* Scene & script

* List

* [PT-BR] expansion_rules adjustment e new errors (home-assistant#1998)

* [PT-BR] add errors

* [PT-BR] expansion_rules adjustment

* add quotation marks

* remove space

* [DE] Add a few more variations to shopping list add item (home-assistant#1985)

* [Fr] Add new intents for cover, valve, vacuum, media player (home-assistant#1973)

* [Fr] Add new intents for cover, valve, vacuum, media player

I had to exclude the vacuum domain in homeassistant_HassTurnOff and homeassistant_HassTurnOn, not sure about the impact of that change.

* Roll back on test/en/media_player_HassMediaNext.yaml

* Update media_player_HassMediaNext.yaml

* [Fr] HassMediaPause.yaml

Changed response and test of HassMediaPause.yaml
--> replace "Pause" with "Lecture en pause"

* [Fr] Reviewed responses and removed expansion_rules

Removed <volume> and <position> expansion rules
Updated tests accordingly
use <regle>, <ouvre> and <ferme> in sentences

* [Fr] Update HassMediaNext

Update the response: Suivant --> Média suivant
Add an expansion_rule <media> with media types (chanson, film...)

* [Fr] Reviewed verbs in new intents

New expansion rules for handling infinitive form of verbs

In the expansion_rule <lire>, I added a nominal form of verbs (lecture, reprise) as they can be used as orders with media players (For example: "Lecture sur la TV" )

Note: I also sorted the expansion rules <capteur> that was in the questions category

* [Fr] fix HassVacuumReturnToBase verb + response update

Use the expansion_rule <renvoie>
Update responses for HassVacuumStart :
"démarré" --> "Nettoyage démarré
and HassMediaUnpause
"Reprise" --> "Lecture relancée"

* [Fr] adjustments on media_player_Hass...

- sentences/fr/_common: split verbs "lire" and "reprendre". add "média" value in <media> expansion_rule
- sentences/fr/media_player_HassUnpause: add an intent to cover "Reprends/reprendre la lecture sur [...]"
- sentences/fr/media_player_HassSetVolume : Deleted unuseful spaces in intent
- test/fr/media_player_HassMediaUnpause: add a test for covering all intents

* Test all YAML sentence files (home-assistant#2003)

* Warn if a test file is not being tested

* Black

* Isort

* Test all files for which we have YAML

* Remove unused import

* pylint

* Ununsed import.......

* Allow other files in intent foler too (home-assistant#2004)

* Allow other files in intent foler too

* Test sentences dir yoooo

* [ES] Add another sentence to turn on/off all lights in an area (home-assistant#2008)

I think it's also very common to say "Enciende el salón" as a way of turning all the lights of an area by name.
It's even more useful to turn things off.

* [ES] Improve success response for turning on a light (home-assistant#2007)

Lights are "encendidas", not "activadas".
Now voice assistant will say: "Luz de la cocina se ha encendido".

* Add new sentence to set a light to a specific brightness (home-assistant#2006)

Enabling "Enciende la luz de la cocina al 30%".

* Suggested custom sentences for media players (home-assistant#1986)

Add more natural sentences for media player control

* fix

* [FR] Set cover position per area, device class, name + area and area awareness  (home-assistant#2002)

* Work complete, all back into a single file for now (Split Not working)

* Removed position. Useless (I checked how we were handling brightness)

* Small Fix on HassNeverMind to remove a warning.

* Splitting the work into domain files

* Removing unneeded article. Correcting answers for domain light (home-assistant#2009)

* [RO] Fix tests (home-assistant#2015)

* fix common sentence

* fix sentences & tests

* fix sentences

* fix sentences and test

* fix sentences and test

* fix fixture

* fix recognition failed

* fix tests

* [FR] Add excluded domains in homeassistant_HassTurnOn/Off (home-assistant#2005)

* [FR] Add excluded domains in homeassistant_HassTurnOn/Off

I noticed problems on my HA main instance if a script name or alias matches homeassistant_HassTurnOn/Off intents.

This PR aligns with the English setup by excluding the following domains besides cover, vacuum, and valves:
            - binary_sensor
            - lock
            - scene
            - script
            - sensor

* [FR] Fix empty line in homeassistant_HassTurnOn.yaml

* [FR] Add empty line in homeassistant_HassTurnOff.yaml

* [FR] Test after lint has failed

* fix tests

* [FI] Add new intents for cover, valve, vacuum, media_player (home-assistant#1990)

* [FI] Add new intents for cover, valve, vacuum, media_player

* fix recognition fail

* fix recognition fail

* [SL] fixed BS motion (home-assistant#2017)

* [CS] Add person state (home-assistant#1997)

* [CS] Add person state

* spaces

* fix home zone

* Addressed scenarios for home and not_home in CZ language

* fix binnary_sensor

* fix script_TurnOn and MediaNext

* fix fan,light,shoppinglist,todo

* fix lock_hassturnoff

* fix fan&lock

* fix tests and sentences

* fix tests and response

* fix tests and response

* fix cover

* fix tests and response

* fix hm_hturnon

* fix tests and response

* fix hasslightset

* fix person

* fix cover_hassgetstate

* fix homeassitant_getstate

* [de-CH] implement new features (including tests) (home-assistant#2020)

* fix hassTurnOn

* fix sensor

* fix sensor

* update tests

* restore lock

* fix lock

* fix sensor

* -.-

* [SL] added HassSetPosition and valve_HassTurnOn (home-assistant#2021)

* [CS] Add HassSetPosition and sensorHassGetState (home-assistant#2022)

* set position

* sensor

* fix broken lights

* fix entity name conflict with area

* weather

* selected binary sensors

* media player

* [HU]valve_HassSetPosition.yaml and cover_HassSetPosition.yaml files should be split (home-assistant#2024)

* [HU[ valve_HassSetPosition.yaml and cover_HassSetPosition.yaml files should be split

* [SL] cover_HassGetState fix (home-assistant#2025)

* [NL] Avoid HassGetState getting triggered on only name (home-assistant#2027)

* [NL] Remove C or F from weather response (home-assistant#2026)

* [SK] Add vacuum intents (home-assistant#2028)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents (home-assistant#2029)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents

* [SK] Add setVolume intent (home-assistant#2030)

* [SK] Add vacuum intents

* [SK] Add vacuum intents - fix lng

* [SK] Add setPosition intents

* [SK] Add setVolume intent

* [SK] Add MediaNextUnPause (home-assistant#2031)

* prettier fix

---------

Co-authored-by: Oleksandr Kapshuk <[email protected]>
Co-authored-by: Michael <[email protected]>
Co-authored-by: steffenrapp <[email protected]>
Co-authored-by: Vaclav <[email protected]>
Co-authored-by: mitrokun <[email protected]>
Co-authored-by: Tudor Sandu <[email protected]>
Co-authored-by: Luiz Oliveira <[email protected]>
Co-authored-by: Jens Reimann <[email protected]>
Co-authored-by: slegars56 <[email protected]>
Co-authored-by: Paulus Schoutsen <[email protected]>
Co-authored-by: Miguel Camba <[email protected]>
Co-authored-by: OzGav <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: JLo <[email protected]>
Co-authored-by: David Marín <[email protected]>
Co-authored-by: salleq <[email protected]>
Co-authored-by: lightningdhna <[email protected]>
Co-authored-by: Andrej Sersen <[email protected]>
Co-authored-by: dontinelli <[email protected]>
Co-authored-by: RViktor <[email protected]>
Co-authored-by: Martijn van der Pol <[email protected]>
Co-authored-by: LubosKadasi <[email protected]>
@dinhchinh82 dinhchinh82 marked this pull request as ready for review March 4, 2024 04:16
@home-assistant home-assistant bot dismissed stale reviews from themself March 4, 2024 04:16

Stale

@dinhchinh82 dinhchinh82 merged commit 8f81859 into home-assistant:main Mar 4, 2024
2 checks passed
schizza pushed a commit to schizza/intents that referenced this pull request Mar 16, 2024
…stant#2023)

Update all the Vietnamese intents up to end of Feb 2024.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant