Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AR] Improve the Arabic language responses #2125

Merged
merged 17 commits into from
Apr 22, 2024

Conversation

omaramin-2000
Copy link
Contributor

Improve the Arabic language responses

Improve the Arabic language responses
@tetele tetele changed the title Update _common.yaml [AR] Improve the Arabic language responses Apr 11, 2024
sentences/ar/_common.yaml Outdated Show resolved Hide resolved
sentences/ar/_common.yaml Outdated Show resolved Hide resolved
sentences/ar/_common.yaml Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 15, 2024 17:50
@omaramin-2000
Copy link
Contributor Author

omaramin-2000 commented Apr 15, 2024

Alright, I need help with the modifications cause the test fails, can you tell me what else I need to modify? @Natfaji @Ahmed-farag36

tests/ar/light_HassLightSet.yaml Show resolved Hide resolved
tests/ar/light_HassLightSet.yaml Show resolved Hide resolved
tests/ar/light_HassLightSet.yaml Show resolved Hide resolved
@omaramin-2000 omaramin-2000 marked this pull request as ready for review April 18, 2024 21:30
@home-assistant home-assistant bot requested a review from Natfaji April 18, 2024 21:30
Copy link
Contributor

@Natfaji Natfaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add both way to say red ("أحمر" and "احمر") to each response

@home-assistant home-assistant bot marked this pull request as draft April 18, 2024 21:42
@omaramin-2000 omaramin-2000 marked this pull request as ready for review April 18, 2024 21:47
@home-assistant home-assistant bot requested a review from Natfaji April 18, 2024 21:47
sentences/ar/_common.yaml Outdated Show resolved Hide resolved
@Natfaji Natfaji merged commit 8b452fc into home-assistant:main Apr 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants