Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[es] Current date and time #2311

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Conversation

davefx
Copy link
Contributor

@davefx davefx commented Jul 12, 2024

Adding Spanish sentences to get current date and time

Summary by CodeRabbit

  • New Features
    • Added Spanish language support for HassGetCurrentDate and HassGetCurrentTime intents in Home Assistant.
    • Introduced Spanish localized responses for current date and time intents.
    • Implemented test cases for the new Spanish language support to ensure accurate responses.

Copy link

coderabbitai bot commented Jul 12, 2024

Walkthrough

Walkthrough

These changes introduce Spanish language support for the HassGetCurrentDate and HassGetCurrentTime intents in Home Assistant. New response templates, localization, and testing files have been added to handle inquiries about the current date and time in Spanish, enabling users to interact seamlessly in their native language.

Changes

Files Change Summary
responses/es/HassGetCurrentDate.yaml Introduced localization for the HassGetCurrentDate intent in Spanish.
responses/es/HassGetCurrentTime.yaml Added a response template for HassGetCurrentTime in Spanish.
sentences/es/homeassistant_HassGetCurrentDate.yaml Provided Spanish language support for HassGetCurrentDate intent.
sentences/es/homeassistant_HassGetCurrentTime.yaml Provided Spanish language support for HassGetCurrentTime intent.
tests/es/homeassistant_HassGetCurrentDate.yaml Added Spanish tests for the HassGetCurrentDate intent.
tests/es/homeassistant_HassGetCurrentTime.yaml Introduced Spanish test cases for the HassGetCurrentTime intent.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5aa7983 and 05445b7.

Files selected for processing (2)
  • responses/es/HassGetCurrentDate.yaml (1 hunks)
  • tests/es/homeassistant_HassGetCurrentDate.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • responses/es/HassGetCurrentDate.yaml
  • tests/es/homeassistant_HassGetCurrentDate.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@davefx davefx changed the title Es/current date and time [es] Current date and time Jul 12, 2024
@davefx davefx enabled auto-merge (squash) July 12, 2024 12:40
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Comment on lines +5 to +23
default: >
{% set next_hour = 0 %}
{% set minute_str = "" %}
{% if slots.time.minute > 0: %}
{% if slots.time.minute == 15: %}
{% set minute_str = "y cuarto" %}
{% elif slots.time.minute == 30: %}
{% set minute_str = "y media" %}
{% elif slots.time.minute < 30: %}
{% set minute_str = 'y {0:01d}'.format(slots.time.minute) %}
{% else: %}
{% set next_hour = 1 %}
{% if slots.time.minute == 45: %}
{% set minute_str = "menos cuarto" %}
{% else: %}
{% set minute_str = 'menos {0:01d}'.format(60 - slots.time.minute) %}
{% endif %}
{% endif %}
{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve indentation and code structure for readability.

The current indentation and structure can be optimized for better readability and maintainability.

      default: >
        {% set next_hour = 0 %}
        {% set minute_str = "" %}
        {% if slots.time.minute > 0 %}
            {% if slots.time.minute == 15 %}
                {% set minute_str = "y cuarto" %}
            {% elif slots.time.minute == 30 %}
                {% set minute_str = "y media" %}
            {% elif slots.time.minute < 30 %}
                {% set minute_str = 'y {0:01d}'.format(slots.time.minute) %}
            {% else %}
                {% set next_hour = 1 %}
                {% if slots.time.minute == 45 %}
                   {% set minute_str = "menos cuarto" %}
                {% else %}
                    {% set minute_str = 'menos {0:01d}'.format(60 - slots.time.minute) %}
                {% endif %}
            {% endif %}
        {% endif %}

Committable suggestion was skipped due to low confidence.

Comment on lines +24 to +49
{% if slots.time.hour + next_hour > 12: %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0: %}
{% set hour12 = 12 %}
{% else: %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 : %}
Es la
{% else: %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0: %}
de la medianoche
{% elif slots.time.hour < 4: %}
de la madrugada
{% elif slots.time.hour < 12: %}
de la mañana
{% elif slots.time.hour == 12: %}
del mediodía
{% elif slots.time.hour < 21: %}
de la tarde
{% else: %}
de la noche
{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve indentation and code structure for readability.

The current indentation and structure can be optimized for better readability and maintainability.

        {% if slots.time.hour + next_hour > 12 %}
            {% set hour12 = slots.time.hour + next_hour - 12 %}
        {% elif slots.time.hour + next_hour == 0 %}
            {% set hour12 = 12 %}
        {% else %}
            {% set hour12 = slots.time.hour + next_hour %}
        {% endif %}
        {% if hour12 == 1 %}
           Es la
        {% else %}
           Son las
        {% endif %}
        {{hour12}} {{minute_str}}
        {% if slots.time.hour == 0 %}
            de la medianoche
        {% elif slots.time.hour < 4 %}
            de la madrugada
        {% elif slots.time.hour < 12 %}
            de la mañana
        {% elif slots.time.hour == 12 %}
            del mediodía
        {% elif slots.time.hour < 21 %}
            de la tarde
        {% else %}
            de la noche
        {% endif %}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{% if slots.time.hour + next_hour > 12: %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0: %}
{% set hour12 = 12 %}
{% else: %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 : %}
Es la
{% else: %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0: %}
de la medianoche
{% elif slots.time.hour < 4: %}
de la madrugada
{% elif slots.time.hour < 12: %}
de la mañana
{% elif slots.time.hour == 12: %}
del mediodía
{% elif slots.time.hour < 21: %}
de la tarde
{% else: %}
de la noche
{% endif %}
{% if slots.time.hour + next_hour > 12 %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0 %}
{% set hour12 = 12 %}
{% else %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 %}
Es la
{% else %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0 %}
de la medianoche
{% elif slots.time.hour < 4 %}
de la madrugada
{% elif slots.time.hour < 12 %}
de la mañana
{% elif slots.time.hour == 12 %}
del mediodía
{% elif slots.time.hour < 21 %}
de la tarde
{% else %}
de la noche
{% endif %}

@davefx davefx merged commit 26fa9bc into home-assistant:main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant