Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[es] Current date and time #2311

Merged
merged 4 commits into from
Jul 12, 2024
Merged

[es] Current date and time #2311

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b87948
Adding Spanish date and time sentences
davefx Jul 12, 2024
ba8f9ae
Fixing some bugs
davefx Jul 12, 2024
5aa7983
Fixing problems
davefx Jul 12, 2024
05445b7
Adding weekday
davefx Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions responses/es/HassGetCurrentDate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
language: es
responses:
intents:
HassGetCurrentDate:
default: >
{% set months = {
1: 'enero',
2: 'febrero',
3: 'marzo',
4: 'abril',
5: 'mayo',
6: 'junio',
7: 'julio',
8: 'agosto',
9: 'septiembre',
10: 'octubre',
11: 'noviembre',
12: 'diciembre',
} %}
Es {{slots.date.day}} de {{ months[slots.date.month] }} de {{ slots.date.year }}
49 changes: 49 additions & 0 deletions responses/es/HassGetCurrentTime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
language: es
responses:
intents:
HassGetCurrentTime:
default: >
{% set next_hour = 0 %}
{% set minute_str = "" %}
{% if slots.time.minute > 0: %}
{% if slots.time.minute == 15: %}
{% set minute_str = "y cuarto" %}
{% elif slots.time.minute == 30: %}
{% set minute_str = "y media" %}
{% elif slots.time.minute < 30: %}
{% set minute_str = 'y {0:01d}'.format(slots.time.minute) %}
{% else: %}
{% set next_hour = 1 %}
{% if slots.time.minute == 45: %}
{% set minute_str = "menos cuarto" %}
{% else: %}
{% set minute_str = 'menos {0:01d}'.format(60 - slots.time.minute) %}
{% endif %}
{% endif %}
{% endif %}
Comment on lines +5 to +23
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve indentation and code structure for readability.

The current indentation and structure can be optimized for better readability and maintainability.

      default: >
        {% set next_hour = 0 %}
        {% set minute_str = "" %}
        {% if slots.time.minute > 0 %}
            {% if slots.time.minute == 15 %}
                {% set minute_str = "y cuarto" %}
            {% elif slots.time.minute == 30 %}
                {% set minute_str = "y media" %}
            {% elif slots.time.minute < 30 %}
                {% set minute_str = 'y {0:01d}'.format(slots.time.minute) %}
            {% else %}
                {% set next_hour = 1 %}
                {% if slots.time.minute == 45 %}
                   {% set minute_str = "menos cuarto" %}
                {% else %}
                    {% set minute_str = 'menos {0:01d}'.format(60 - slots.time.minute) %}
                {% endif %}
            {% endif %}
        {% endif %}

Committable suggestion was skipped due to low confidence.

{% if slots.time.hour + next_hour > 12: %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0: %}
{% set hour12 = 12 %}
{% else: %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 : %}
Es la
{% else: %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0: %}
de la medianoche
{% elif slots.time.hour < 4: %}
de la madrugada
{% elif slots.time.hour < 12: %}
de la mañana
{% elif slots.time.hour == 12: %}
del mediodía
{% elif slots.time.hour < 21: %}
de la tarde
{% else: %}
de la noche
{% endif %}
Comment on lines +24 to +49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve indentation and code structure for readability.

The current indentation and structure can be optimized for better readability and maintainability.

        {% if slots.time.hour + next_hour > 12 %}
            {% set hour12 = slots.time.hour + next_hour - 12 %}
        {% elif slots.time.hour + next_hour == 0 %}
            {% set hour12 = 12 %}
        {% else %}
            {% set hour12 = slots.time.hour + next_hour %}
        {% endif %}
        {% if hour12 == 1 %}
           Es la
        {% else %}
           Son las
        {% endif %}
        {{hour12}} {{minute_str}}
        {% if slots.time.hour == 0 %}
            de la medianoche
        {% elif slots.time.hour < 4 %}
            de la madrugada
        {% elif slots.time.hour < 12 %}
            de la mañana
        {% elif slots.time.hour == 12 %}
            del mediodía
        {% elif slots.time.hour < 21 %}
            de la tarde
        {% else %}
            de la noche
        {% endif %}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{% if slots.time.hour + next_hour > 12: %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0: %}
{% set hour12 = 12 %}
{% else: %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 : %}
Es la
{% else: %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0: %}
de la medianoche
{% elif slots.time.hour < 4: %}
de la madrugada
{% elif slots.time.hour < 12: %}
de la mañana
{% elif slots.time.hour == 12: %}
del mediodía
{% elif slots.time.hour < 21: %}
de la tarde
{% else: %}
de la noche
{% endif %}
{% if slots.time.hour + next_hour > 12 %}
{% set hour12 = slots.time.hour + next_hour - 12 %}
{% elif slots.time.hour + next_hour == 0 %}
{% set hour12 = 12 %}
{% else %}
{% set hour12 = slots.time.hour + next_hour %}
{% endif %}
{% if hour12 == 1 %}
Es la
{% else %}
Son las
{% endif %}
{{hour12}} {{minute_str}}
{% if slots.time.hour == 0 %}
de la medianoche
{% elif slots.time.hour < 4 %}
de la madrugada
{% elif slots.time.hour < 12 %}
de la mañana
{% elif slots.time.hour == 12 %}
del mediodía
{% elif slots.time.hour < 21 %}
de la tarde
{% else %}
de la noche
{% endif %}

8 changes: 8 additions & 0 deletions sentences/es/homeassistant_HassGetCurrentDate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
language: es
intents:
HassGetCurrentDate:
data:
- sentences:
- "[<dime> ]qué (día|fecha) es[ hoy]"
- "[<dime> ](a|en) qué (día|fecha) estamos[ hoy]"
- "<dime> la fecha"
7 changes: 7 additions & 0 deletions sentences/es/homeassistant_HassGetCurrentTime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
language: es
intents:
HassGetCurrentTime:
data:
- sentences:
- "[<dime> ]qué hora es[ ahora]"
- "<dime> la hora[ actual]"
9 changes: 9 additions & 0 deletions tests/es/homeassistant_HassGetCurrentDate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
language: es
tests:
- sentences:
- "qué día es hoy"
- "dime a qué fecha estamos"
- "dime la fecha"
intent:
name: HassGetCurrentDate
response: Es 17 de septiembre de 2013
10 changes: 10 additions & 0 deletions tests/es/homeassistant_HassGetCurrentTime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
language: es
tests:
- sentences:
- "qué hora es"
- "dime la hora actual"
- "dime la hora"
- "dime qué hora es"
intent:
name: HassGetCurrentTime
response: Es la 1 y 2 de la madrugada
Loading