Use bonjour advertiser as default again, warn when Avahi is used on an unsupported platform. #927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
For the beta period of 0.10.0 we changed how we select the default advertiser, moving from
bonjour
toavahi
as a default if we our heuristic detects it being available on the platform.This heuristic might not be perfect and might result in non advertised HAP service (see homebridge/homebridge#3062 (comment)).
💡 Proposed solution
To avoid any breaking changes for existing users, this PR revers the default advertiser back to the
bonjour
package.⚙️ Release Notes
bonjour
as the default advertiser.➕ Additional Information
When selecting the
avahi
advertiser, this PR will now additionally run the availability check, and revert tobonjour
if we find to be running on a non compatible platform. Additionally, we print an error message informing the user about it.Testing
--
Reviewer Nudging
--