Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bonjour advertiser as default again, warn when Avahi is used on an unsupported platform. #927

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Use bonjour advertiser as default again, warn when Avahi is used on an unsupported platform. #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/lib/Accessory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,10 +1220,14 @@ export class Accessory extends EventEmitter {
// create our Advertiser which broadcasts our presence over mdns
const parsed = Accessory.parseBindOption(info);

const defaultAdvertiser = info.advertiser
?? (await AvahiAdvertiser.isAvailable() ? MDNSAdvertiser.AVAHI : MDNSAdvertiser.BONJOUR);
let selectedAdvertiser = info.advertiser ?? MDNSAdvertiser.BONJOUR;
if (info.advertiser === MDNSAdvertiser.AVAHI && !await AvahiAdvertiser.isAvailable()) {
console.error("[${this.displayName}] Selected \"" + MDNSAdvertiser.AVAHI + "\" advertiser though it isn't available on the platform. " +
"Reverting to \"" + MDNSAdvertiser.BONJOUR + "\"");
selectedAdvertiser = MDNSAdvertiser.BONJOUR;
}

switch (defaultAdvertiser) {
switch (selectedAdvertiser) {
case MDNSAdvertiser.CIAO:
this._advertiser = new CiaoAdvertiser(this._accessoryInfo, {
interface: parsed.advertiserAddress,
Expand Down