Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pod-exec and node-exec #628

Merged
merged 2 commits into from
May 23, 2024

Fix issue with exec and TTY over teleport

ddb4ed9
Select commit
Loading
Failed to load commit list.
Merged

Rework pod-exec and node-exec #628

Fix issue with exec and TTY over teleport
ddb4ed9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 23, 2024 in 0s

11.26% (+0.14%) compared to 405d2b4

View this Pull Request on Codecov

11.26% (+0.14%) compared to 405d2b4

Details

Codecov Report

Attention: Patch coverage is 8.99471% with 172 lines in your changes are missing coverage. Please review.

Project coverage is 11.26%. Comparing base (405d2b4) to head (ddb4ed9).

Files Patch % Lines
pkg/havener/kubexec.go 0.00% 56 Missing ⚠️
internal/cmd/nexec.go 14.06% 55 Missing ⚠️
internal/cmd/pexec.go 16.21% 31 Missing ⚠️
pkg/havener/top.go 0.00% 12 Missing ⚠️
pkg/havener/logs.go 0.00% 10 Missing ⚠️
internal/cmd/common.go 0.00% 3 Missing ⚠️
pkg/havener/common.go 0.00% 3 Missing ⚠️
internal/cmd/events.go 0.00% 1 Missing ⚠️
pkg/havener/havener.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   11.11%   11.26%   +0.14%     
==========================================
  Files          20       20              
  Lines        1881     1927      +46     
==========================================
+ Hits          209      217       +8     
- Misses       1668     1706      +38     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.