Revert the revert of "pre-define map capacities" #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a6e8087.
kentquirk
requested review from
MikeGoldsmith
and removed request for
emilyashley
MikeGoldsmith
approved these changes
Oct 19, 2022
MikeGoldsmith
added
version: bump patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #200, which was a revert of a performance PR.
I tried implementing the change that I was intending to make, and it just doesn't work well.
A simple change runs the risk of blowing up memory in certain situations, so I had intended to make it configurable. But as a low-level library, libhoney-go has a well-trodden configuration path and doesn't really have a configuration model that allows for a transparent change. It would have needed to read the environment from within the libhoney Init() method and that's not really a good design. Otherwise we'd have to make all the callers of libhoney set it explicitly.
My intent was a simpler solution, but this is the simpler solution, it turns out. Oh well.