feat(windows) additions to the API #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they are out of date!
update docs link
The documentation missed the compiletime requirement `libdbus-1-dev`. When using this crate without having `libdbus-1-dev` installed, `cargo build` fails with the following error message on a linux system: ``` error: failed to run custom build command for `dbus v0.4.1` process didn't exit successfully: `[…]target/debug/build/dbus-17d90d6172f41386/build-script-build` (exit code: 101) --- stderr thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: "`\"pkg-config\" \"--libs\" \"--cflags\" \"dbus-1\"` did not exit successfully: exit code: 1\n--- stderr\nPackage dbus-1 was not found in the pkg-config search path.\nPerhaps you should add the directory containing `dbus-1.pc\'\nto the PKG_CONFIG_PATH environment variable\nNo package \'dbus-1\' found\n"', libcore/result.rs:945:5 note: Run with `RUST_BACKTRACE=1` for a backtrace. warning: build failed, waiting for other jobs to finish... error: build failed ``` Additionally, the examples missed `external create notify_rust;`. `cargo build` fails with the following message in that case: ``` 1 | use notify_rust::Notification; | ^^^^^^^^^^^ Maybe a missing `extern crate notify_rust;`? ```
Complement requirements documentation and examples
luckily the server never was considered stable, this changes it's semantics severely, everything else should be fine
update dbus-rs to 0.6
not supported anyway, sorry, not sorry
you aren't using that are you?
Feature/native errors
…macos"))`" This reverts commit b381443.
12 tasks
|
@hoodie can you review this PR? I'd be happy to fix or implement anything that's missing. |
|
oh yes, I was kinda waiting for you to rebase it and forgot about it since. |
|
I think I messed up the branch here so I'm starting a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.