Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tauri) add Notifications API #505

Merged
merged 16 commits into from
Jun 15, 2020
Merged

feat(tauri) add Notifications API #505

merged 16 commits into from
Jun 15, 2020

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@rajivshah3
Copy link
Member

Just a heads-up: mac-notification-sys (used by notify-rust on macOS) uses the deprecated NSUserNotification API, which is deprecated after macOS 10.14 (see h4llow3En/mac-notification-sys#10)

@jbolda
Copy link
Member

jbolda commented Apr 12, 2020

Also waiting on upstream PR for windows support: hoodie/notify-rust#68

@lucasfernog lucasfernog changed the title feat(tauri) add Notifications API (lin and mac only) feat(tauri) add Notifications API May 2, 2020
@lucasfernog lucasfernog marked this pull request as ready for review May 2, 2020 23:26
@lucasfernog lucasfernog requested review from a team May 2, 2020 23:26
@lucasfernog lucasfernog requested a review from a team May 8, 2020 15:30
@lucasfernog lucasfernog requested a review from a team as a code owner June 15, 2020 03:14
@lucasfernog lucasfernog merged commit 406dea7 into dev Jun 15, 2020
@lucasfernog lucasfernog deleted the feature/notification branch June 15, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants