Make task auto-unlock duration configurable #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `TASK_AUTOUNLOCK_AFTER` configuration setting to server that allows task auto-unlock delay to be configured (defaults to 2 hours, preserving prior behavior) * Include configured delay in task data sent to front-end * Update front-end task timer to make use of delay duration provided by server instead of using hard-coded 2 hours
|
Tested for the following configurations.
In all the cases time left is displayed in minutes like Just thinking if we could get to display units in hours & days if the auto unlock duration exceeds an hour. Like:
@nrotstan @ethan-nelson - what do you think here? |
|
I think that's a good point, but I'd throw it into a new ticket--I don't see it as an immediate blocker for this. |
|
Also I really like including this in the API data sent to the frontend 👍 |
ethan-nelson
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
This also works for me. Captured discussion in #1291 about the front end formatting changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
TASK_AUTOUNLOCK_AFTERconfiguration setting to server thatallows task auto-unlock delay to be configured (defaults to 2 hours,
preserving prior behavior)
Include configured delay in task data sent to front-end
Update front-end task timer to make use of delay duration provided by
server instead of using hard-coded 2 hours