3.1.0: Mostly refinements (develop -> master) #1292
Conversation
* Add `TASK_AUTOUNLOCK_AFTER` configuration setting to server that allows task auto-unlock delay to be configured (defaults to 2 hours, preserving prior behavior) * Include configured delay in task data sent to front-end * Update front-end task timer to make use of delay duration provided by server instead of using hard-coded 2 hours
Add {{ 'x' | translate }} to text which did not have it
Add more homepage stats
fix whitespace between menubar and page content
title changes while browsing #860
Due to other PR merges, the database revision base was out-of-date. I also updated the date in case any routines use delta t for some reason.
Split non square tasks
…counts Fixes #792 where validation and mapping counts incorrect on profile
…elay Make task auto-unlock duration configurable
|
Given that there is a db migration needed, I recommend we do a minor version update (v3.1.0) The new homepage stats haven't been added to the homepage UI yet. Is there a plan to add those? Or are they going to be displayed somewhere else? Lastly, can someone with an project manager account create a new task on the staging server or give me permissions for that? |
They won't be added to front page to be viewable. Just API accessible for now.
Done. |
There was a problem hiding this comment.
I have been testing the features on the staging server, everything seems to be working great.
Notes:
- It might be useful to allow the task unlock time to be changed by admins in the UI somewhere.
- I couldn't check on the staging server the fix to user's projects mapped and validated, that table doesn't even show up. Not sure what the issue is there.
|
Thanks @dakotabenjamin for the review. Regarding the user profile, it looks like it does work on stage but just takes a while--I'm guessing that is because it is a small DB instance. https://tasks-stage.hotosm.org/user/FTA loaded for me after about ~30 seconds. We probably need to revisit the task time calculation again at some point, or perhaps load that after the table since it is a bit more complex. |
|
I'll do a run through tonight on staging as well. |
|
A lesson in patience 😁 |
Add missing spaces to About and FAQ pages
|
Thanks @smit1678 for that catch. I added some comments in slack that I hope we can find a better way in general for translating strings that include a link other than putting the html in the string. I retested these changes and they are working fine for me (since I can't approve my own PR) |
|
I'll plan to merge tomorrow night (2018-12-15 0000GMT) unless something is brought up before then. |
|
How did you reproduce the bug? Does it always happen for you? It would seem that this bug is already present in |
|
@dakotabenjamin I was testing the non-square tasks being split. This isn't available in master. But I did just test square tasks in master and it looks like that issue is there now. To reproduce:
|
|
Hm, I can't get that to reproduce on projects I've created, but I can see the issue on your project: https://tasks-stage.hotosm.org/project/5538 I even tried making a project with the same boundaries as your lisbon one but couldn't get it to malfunction. What should we do in this case? |
New projects or ones that you created a while back? @ramyaragupathy had reproduced this, did you do anything specific? |
Add/eoy banner
Adjust donor number
ethan-nelson
changed the title
We're working on a release with more of our Hacktoberfest PRs (as well as some that were collecting some dust). Most of these relate to feature or visual refinements:
<title>so tabs and history lists can be navigated (title changes while browsing #860 #1252)Please provide feedback! All of these changes are on the TM at https://tasks-stage.hotosm.org. We are looking to merge around Dec. 14.