Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid to split tasks with zoom level >=18 or area < 25k m2 #4055

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Forbid to split tasks with zoom level >=18 or area < 25k m2 #4055

merged 3 commits into from
Jan 19, 2021

Conversation

willemarcel
Copy link
Contributor

Resolves #3428

@willemarcel willemarcel added this to the v4.2.5 milestone Jan 6, 2021
@willemarcel willemarcel added Difficulty: 3 type: enhancement Improving an existing functionality labels Jan 7, 2021
ramyaragupathy
ramyaragupathy approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@ramyaragupathy ramyaragupathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per conversation - updated the code:

  • to fetch geometry in WKB format
  • convert WKB to Geography
  • use area function on the new geography

Rest of the changes looks good

@willemarcel willemarcel changed the title Forbid to split tiny tasks (zoom level >=18 or area < 5e-07) Forbid to split tiny tasks (zoom level >=18 or area < 25k m²) Jan 19, 2021
@willemarcel willemarcel changed the title Forbid to split tiny tasks (zoom level >=18 or area < 25k m²) Forbid to split tasks with zoom level >=18 or area < 25k m² Jan 19, 2021
@willemarcel willemarcel merged commit 136d360 into develop Jan 19, 2021
@willemarcel willemarcel deleted the feature/split-task-limit branch January 19, 2021 10:43
@ramyaragupathy ramyaragupathy changed the title Forbid to split tasks with zoom level >=18 or area < 25k m² Forbid to split tasks with zoom level >=18 or area < 25k m Jan 19, 2021
@ramyaragupathy ramyaragupathy changed the title Forbid to split tasks with zoom level >=18 or area < 25k m Forbid to split tasks with zoom level >=18 or area < 25k m2 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramyaragupathy ramyaragupathy ramyaragupathy approved these changes

Assignees
No one assigned
Labels
scope: backend scope: frontend type: enhancement Improving an existing functionality
Projects
None yet
Milestone
v4.2.5
Development

Successfully merging this pull request may close these issues.

Limit split levels
2 participants
@willemarcel @ramyaragupathy