Forbid to split tasks with zoom level >=18 or area < 25k m2

backend/models/postgis/utils.py

@@ -76,6 +76,13 @@ class ST_Area(GenericFunction):
     type = None
 
 
+class ST_GeogFromWKB(GenericFunction):
+    """ Exposes PostGIS ST_GeogFromWKB function """
+
+    name = "ST_GeogFromWKB"
+    type = None
+
+
 class ST_Buffer(GenericFunction):
     """ Exposes PostGIS ST_Buffer function """
 

backend/services/grid/split_service.py

@@ -6,7 +6,7 @@
 from geoalchemy2 import shape
 from backend.models.dtos.grid_dto import SplitTaskDTO
 from backend.models.dtos.mapping_dto import TaskDTOs
-from backend.models.postgis.utils import ST_Transform
+from backend.models.postgis.utils import ST_Transform, ST_Area, ST_GeogFromWKB
 from backend.models.postgis.task import Task, TaskStatus, TaskAction
 from backend.models.postgis.project import Project
 from backend.models.postgis.utils import NotFound, InvalidGeoJson
@@ -171,6 +171,16 @@ def split_task(split_task_dto: SplitTaskDTO) -> TaskDTOs:
 
         original_geometry = shape.to_shape(original_task.geometry)
 
+        # Fetch the task geometry in meters
+        original_task_area_m = db.engine.execute(
+            ST_Area(ST_GeogFromWKB(original_task.geometry))
+        ).scalar()
+
+        if (
+            original_task.zoom and original_task.zoom >= 18
+        ) or original_task_area_m < 25000:
+            raise SplitServiceError("Task is too small to be split")
+
         # check its locked for mapping by the current user
         if TaskStatus(original_task.task_status) != TaskStatus.LOCKED_FOR_MAPPING:
             raise SplitServiceError("Status must be LOCKED_FOR_MAPPING to split")

frontend/src/components/taskSelection/actionSidebars.js

@@ -38,6 +38,7 @@ export function CompletionTabForMapping({
   const token = useSelector((state) => state.auth.get('token'));
   const [showHelp, setShowHelp] = useState(false);
   const [showMapChangesModal, setShowMapChangesModal] = useState(false);
+  const [splitTaskError, setSplitTaskError] = useState(false);
   const radioInput = 'radio-input input-reset pointer v-mid dib h2 w2 mr2 br-100 ba b--blue-light';
   const fetchLockedTasks = useFetchLockedTasks();
   const clearLockedTasks = useClearLockedTasks();
@@ -48,10 +49,14 @@ export function CompletionTabForMapping({
         `projects/${project.projectId}/tasks/actions/split/${tasksIds[0]}/`,
         token,
         'POST',
-      ).then((r) => {
-        clearLockedTasks();
-        navigate(`../tasks/`);
-      });
+      )
+        .then((r) => {
+          clearLockedTasks();
+          navigate(`../tasks/`);
+        })
+        .catch((e) => {
+          setSplitTaskError(true);
+        });
     } else {
       setShowMapChangesModal('split');
     }
@@ -107,6 +112,17 @@ export function CompletionTabForMapping({
           {(close) => <UnsavedMapChangesModalContent close={close} action={showMapChangesModal} />}
         </Popup>
       )}
+      {splitTaskError && (
+        <Popup
+          modal
+          open
+          closeOnEscape={true}
+          closeOnDocumentClick={true}
+          onClose={() => setSplitTaskError(false)}
+        >
+          {(close) => <TaskSplitErrorModalContent close={close} />}
+        </Popup>
+      )}
       {showReadCommentsAlert && (
         <div
           className="tc pa2 mb1 bg-grey-light blue-dark pointer"
@@ -444,6 +460,25 @@ function UnsavedMapChangesModalContent({ close, action }: Object) {
   );
 }
 
+function TaskSplitErrorModalContent({ close }: Object) {
+  return (
+    <div className="blue-dark bg-white pv2 pv4-ns ph2 ph4-ns tc">
+      <div className="cf tc orange pb3">
+        <AlertIcon height="50px" width="50px" />
+      </div>
+      <h3 className="barlow-condensed f3 fw6 mv0">
+        <FormattedMessage {...messages.splitTaskError} />
+      </h3>
+      <div className="mv4 lh-title">
+        <FormattedMessage {...messages.splitTaskErrorDescription} />
+      </div>
+      <Button className="bg-red white" onClick={() => close()}>
+        <FormattedMessage {...messages.closeModal} />
+      </Button>
+    </div>
+  );
+}
+
 function TaskSpecificInstructions({ instructions, open = true }: Object) {
   const [isOpen, setIsOpen] = useState(open);
   return (

frontend/src/components/taskSelection/messages.js

@@ -411,6 +411,14 @@ export default defineMessages({
     id: 'project.tasks.action.split_task',
     defaultMessage: 'Split task',
   },
+  splitTaskError: {
+    id: 'project.tasks.action.split_task.error',
+    defaultMessage: 'It was not possible to split the task',
+  },
+  splitTaskErrorDescription: {
+    id: 'project.tasks.action.split_task.error.description',
+    defaultMessage: 'This task is already too small and can not be split.',
+  },
   selectAnotherTask: {
     id: 'project.tasks.action.select_another_task',
     defaultMessage: 'Select another task',

frontend/src/locales/en.json

@@ -602,6 +602,8 @@
   "project.tasks.action.options.incomplete": "No",
   "project.tasks.action.options.bad_imagery": "The imagery is bad",
   "project.tasks.action.split_task": "Split task",
+  "project.tasks.action.split_task.error": "It was not possible to split the task",
+  "project.tasks.action.split_task.error.description": "This task is already too small and can not be split.",
   "project.tasks.action.select_another_task": "Select another task",
   "project.tasks.action.stop_validation": "Stop validation",
   "project.tasks.action.tasks_map": "Tasks map",