Removes build word references from TaskRun #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present `TaskRun's` `status`, it's pod containers name(`step name` prefix) and logs has references to `build` keyword. Which kind of gives the perception that `Task` is intended to perform only build operations. This patch removes those references from `TaskRun`. Fixes - tektoncd#815
At present `TaskRun's` `status`, it's pod containers name(`step name` prefix) and logs has references to `build` keyword. Which kind of gives the perception that `Task` is intended to perform only build operations. This patch removes those references from `TaskRun`. Fixes - tektoncd#815
vdemeester
force-pushed
the
fix-815
branch
5 times, most recently
from
5e530f3
to
58ed222
Compare
hrishin
pushed a commit
that referenced
this pull request
Sep 3, 2019
Initial commit for OpenShift CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
At present
TaskRun'sstatus, it's pod containers name(step nameprefix) and logs has references to
buildkeyword.Which kind of gives the perception that
Taskis intended toperform only build operations.
This patch removes those references from
TaskRun.Fixes
Submitter Checklist