Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "build" #815

Closed
imjasonh opened this issue Apr 30, 2019 · 1 comment · Fixed by #818 or #1226
Closed

Remove references to "build" #815

imjasonh opened this issue Apr 30, 2019 · 1 comment · Fixed by #818 or #1226
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@imjasonh
Copy link
Member

Expected Behavior

TaskRuns are not assumed to be "building" something; they can do anything, including tests, deployments, busy-waits, making sandwiches

Actual Behavior

TaskRuns describe things in terms of "build" all over the place, including (but not limited to):

  • A running TaskRun's status is Building (here) -- this could be changed to Running
  • A TaskRun's Pod has containers named like build-step-${step-name} (here) -- this could be changed to step-
  • TaskRun logs end with a line saying Build successful (here) -- this could be changed to TaskRun successful, or just not log anything.

(There are probably more)
@imjasonh imjasonh added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Apr 30, 2019
hrishin added a commit to hrishin/tekton-pipeline that referenced this issue Apr 30, 2019
@hrishin
Removes build word references from TaskRun
28eecf2 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815
@hrishin hrishin mentioned this issue Apr 30, 2019
Merged
3 tasks
hrishin added a commit to hrishin/tekton-pipeline that referenced this issue May 7, 2019
@hrishin
Removes build word references from TaskRun
51a9d0e 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815
aristosvo added a commit to aristosvo/pipeline that referenced this issue May 25, 2019
@aristosvo
Removes build word references from TaskRun
4fe5707 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815
@aristosvo aristosvo mentioned this issue May 25, 2019
Closed
3 tasks
vdemeester pushed a commit to hrishin/tekton-pipeline that referenced this issue May 29, 2019
@hrishin @vdemeester
Removes build word references from TaskRun
66f228d 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815
vdemeester added a commit to hrishin/tekton-pipeline that referenced this issue May 29, 2019
@vdemeester
Removes build word references from TaskRun
b9b44e9 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815

Signed-off-by: Vincent Demeester <[email protected]>
vdemeester pushed a commit to vdemeester/tektoncd-pipeline that referenced this issue May 29, 2019
@hrishin @vdemeester
Removes build word references from TaskRun
1c1ce14 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815

Signed-off-by: Vincent Demeester <[email protected]>
vdemeester pushed a commit to hrishin/tekton-pipeline that referenced this issue May 29, 2019
@hrishin @vdemeester
Removes build word references from TaskRun
5e530f3 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815

Signed-off-by: Vincent Demeester <[email protected]>
vdemeester pushed a commit to hrishin/tekton-pipeline that referenced this issue May 30, 2019
@hrishin @vdemeester
Removes build word references from TaskRun
58ed222 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - tektoncd#815

Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot pushed a commit that referenced this issue Jun 4, 2019
@hrishin @tekton-robot
Removes build word references from TaskRun
3d87e2e 
At present `TaskRun's` `status`, it's pod containers name(`step name`
prefix) and logs has references to `build` keyword.
Which kind of gives the perception that `Task` is intended to
perform only build operations.

This patch removes those references from `TaskRun`.

Fixes
 - #815

Signed-off-by: Vincent Demeester <[email protected]>
@hrishin hrishin mentioned this issue Jun 27, 2019
Closed
@imjasonh
Copy link
Member Author

Looks like there's still at least one lingering reference:

  • TaskRuns in progress have Reason: Building (from here) -- I'm not sure what the difference is between ReasonBuilding and ReasonRunning, but any place we use Building we should use Running instead.

@imjasonh imjasonh reopened this Aug 16, 2019
imjasonh added a commit to imjasonh/pipeline that referenced this issue Aug 21, 2019
@imjasonh
Remove "Building" status reason
fad2421 
This was a vestige of the days when Tekton (née "build pipelines") was
focused on "building" instead of arbitrary "task execution".

Fixes tektoncd#815
@imjasonh imjasonh mentioned this issue Aug 21, 2019
Merged
imjasonh added a commit to imjasonh/pipeline that referenced this issue Aug 21, 2019
@imjasonh
Remove "Building" status reason
93e58a3 
This was a vestige of the days when Tekton (née "build pipelines") was
focused on "building" instead of arbitrary "task execution".

Fixes tektoncd#815
tekton-robot pushed a commit that referenced this issue Aug 21, 2019
@imjasonh @tekton-robot
Remove "Building" status reason
b810085 
This was a vestige of the days when Tekton (née "build pipelines") was
focused on "building" instead of arbitrary "task execution".

Fixes #815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
1 participant
@imjasonh