Better wrapper system, warning fixes #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Closed
Closed
ghost
mentioned this pull request
5 tasks
ghost
mentioned this pull request
5 tasks
ghost
mentioned this pull request
5 tasks
Open
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now everything uses Wrap<> (I hope it works on all the compilers; works fine on GCC 4.6.3).
I didn't remove all the RETURN() and PARAM() though, we should do it progressively (except if someone is motivated enough to do it by hand ;) ).
I also fixed most warnings (probably not important though) and did some minor changes related to these changes (sceIoReadBufferPositive() now returns 1, __KernelReSchedule() is ran in event flags (note this may not be correct but at least there's no reason it wouldn't work), etc).