fix: sync up with nightly futures_api #176
Conversation
Now that http-rs/http-service#14 has landed, update dep versions. (Though this also requires http-rs/http-service#17 now)
|
http-rs/http-service#14 has landed, but probably needs http-rs/http-service#17 too to land now. Meanwhile, updated the http-service-* versions to correspond to the bumped versions. Edit: Both landed. Ready to be merged. |
|
@prasannavl do you want to disable clippy on the travis config? We keep getting nightlies without it, which renders CI useless. |
|
@aturon - ah, I did check for the nightly where everything built. Looks like I was off by 1 day. Fixed it up to later nightly. Hopefully, this should build (unless I was off by one day again). Edit: Okay, I was indeed off by a day, but clippy built on this one - but let me fix up the lifetime lints as well, while at it. Give me a minute, checking it out locally to fix up |
* expand on endpoint Fn's * use ready! macro instead
|
Wait. What? This looks like bogus lint failures. (Although there are other linting pragmas that could be added and probably needs fixing like Debug impls for a bunch. But will open a separate PR for that.) @aturon - or would you like me to add Otherwise, I think this is ready to be merged. |
|
Weird error from Travis -- wanna take a look? Otherwise I can grab this locally and see if I can figure it out... |
|
I assumed it probably had to do with async await that clippy likely hadn't caught up yet. My first thought was to add Thought I'll do another PR with that and some more clippy pragmas next - but yes, would be helpful if you could just make sure that was a bogus lint error and I'm not missing something. |
|
@prasannavl I opened rust-lang/rust-clippy#3988 for it, it's definitely a clippy bug that it's warning about the lifetime generated as part of the async desugaring. |
|
@prasannavl I'm +1 on adding |
Add some good practise pragmas. Additionally, this also worksaround clippy bug allowing it to pass with the addition of crate level `#![allow(clippy::needless_lifetimes)]`. It's applied on a crate level so as to avoid this from being added repeatedly across the modules or functions - and since it's strictly a temporary measure. Related: http-rs#176
|
@yoshuawuyts - Done. So sorry, instead of a PR, I accidentally committed it directly on the master (forgetting I had commit rights on this now - since GitHub usually auto forks when I don't when making small changes directly) |
|
@prasannavl hah, yeah no worries. -- could you rebase this branch then tho so we can get this build to pass? |
|
yup, just doing that locally, and tests were still failing due to examples failing - so seeing if I can fix it quickly, otherwise will just push it rebased |
Now that http-rs/http-service#14 has landed, update dep versions. (Though this also requires http-rs/http-service#17 now)
…tide into futures_update_2017_04
Sync up the new changes in the nightly futures_api: futures dependency to 0.3.0-alpha.14
Also, updated all patch versions of other deps, while at it.
Blocker for successful build/release: http-rs/http-service#14