Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needless_lifetimes: false positive with async fn #3988

Closed
Nemo157 opened this issue Apr 18, 2019 · 2 comments · Fixed by #4266
Closed

needless_lifetimes: false positive with async fn #3988

Nemo157 opened this issue Apr 18, 2019 · 2 comments · Fixed by #4266
Assignees
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy T-async-await Type: Issues related to async/await

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 18, 2019

Minimal repro:

#![feature(futures_api)]

pub struct Foo;
impl Foo {
    pub async fn foo(&mut self) {
    }
}

(playground), gives (with clippy 0.0.212 (2019-04-14 fbb3a47))

warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
 --> src/lib.rs:5:5
  |
5 | /     pub async fn foo(&mut self) {
6 | |     }
  | |_____^
  |
  = note: #[warn(clippy::needless_lifetimes)] on by default
@flip1995 flip1995 added the C-bug Category: Clippy is not doing the correct thing label Apr 18, 2019
@oli-obk
Copy link
Contributor

oli-obk commented May 14, 2019

We need to ignore late bound lifetimes in the needless_lifetimes lint.

@oli-obk oli-obk added the good-first-issue These issues are a good way to get started with Clippy label May 14, 2019
@realcr
Copy link

realcr commented May 14, 2019

I think that a similar problems happens on my side:

error: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
  --> components/common/src/state_service.rs:37:5
   |
37 | /     pub async fn request_state(&mut self) -> Result<StateResponse<ST, MU>, StateClientError> {
38 | |         let (response_sender, response_receiver) = oneshot::channel();
39 | |         let state_request = StateRequest { response_sender };
40 | |
...  |
44 | |         Ok(await!(response_receiver).map_err(|_| StateClientError::ReceiveResponseError)?)
45 | |     }
   | |_____^

rustc version:

$ rustc --version
rustc 1.36.0-nightly (af98304b9 2019-05-11)

@phansch phansch self-assigned this May 20, 2019
@flip1995 flip1995 added the T-async-await Type: Issues related to async/await label Jun 22, 2019
bors added a commit that referenced this issue Jul 23, 2019
Ignore generated fresh lifetimes in elision check

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [ ] Followed [lint naming conventions][lint_naming]
- [ ] Added passing UI tests (including committed `.stderr` file)
- [ ] `cargo test` passes locally
- [ ] Executed `util/dev update_lints`
- [ ] Added lint documentation
- [ ] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

fixes #3988

changelog: Ignore generated fresh lifetimes in elision check.

**HELP**: It seems `tests/ui` are compiled under edition 2015, and I don't know how to add tests for this properly.

Here is the test input it had already passed:
```rust
#![feature(async_await)]
#![allow(dead_code)]

async fn sink1<'a>(_: &'a str) {} // lint
async fn sink1_elided(_: &str) {} // ok

async fn one_to_one<'a>(s: &'a str) -> &'a str { s } // lint
async fn one_to_one_elided(s: &str) -> &str { s } // ok
async fn all_to_one<'a>(a: &'a str, _b: &'a str) -> &'a str { a } // ok
// async fn unrelated(_: &str, _: &str) {} // Not allowed in async fn

// #3988
struct Foo;
impl Foo {
    pub async fn foo(&mut self) {} // ok
}

// rust-lang/rust#61115
async fn print(s: &str) { // ok
    println!("{}", s);
}

fn main() {}

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing good-first-issue These issues are a good way to get started with Clippy T-async-await Type: Issues related to async/await
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants