Implement pagination on list of private+public repos of a user. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paginated version of listRepositories() was missing at GHMyself: as side-effect of this bug when requesting a paginated list of repositories the ones privately owned by a user were not shown. This was caused by the missing override of the listRepositories(final int pageSize) at GHMyself that caused the GHPerson implementation to invoked. The GHPerson version uses the /users/:org/repos?per_page=x URL which *works fine* for organisations but unfortunately *does not return* private repositories for users. IMHO GitHub API are quite inconsistent form this point of view, but they are documented in this way so that work (inconsistently) as designed.
|
Kohsuke Kawaguchi » github-api #205 SUCCESS |
kohsuke
added a commit
that referenced
this pull request
Jul 5, 2014
Implement pagination on list of private+public repos of a user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paginated version of listRepositories() was
missing at GHMyself: as side-effect of this bug
when requesting a paginated list of repositories
the ones privately owned by a user were not shown.
This was caused by the missing override of the
listRepositories(final int pageSize) at GHMyself
that caused the GHPerson implementation to invoked.
The GHPerson version uses the /users/:org/repos?per_page=x
URL which works fine for organisations but unfortunately
does not return private repositories for users.
IMHO GitHub API are quite inconsistent form this
point of view, but they are documented in this way
so that work (inconsistently) as designed.