Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pagination on list of private+public repos of a user. #106

Merged
merged 1 commit into from
Jul 5, 2014
Merged

Implement pagination on list of private+public repos of a user. #106

merged 1 commit into from
Jul 5, 2014

Commits on Jul 3, 2014

  1. Implement pagination on list of private+public repos of a user. 

    The paginated version of listRepositories() was 
missing at GHMyself: as side-effect of this bug
when requesting a paginated list of repositories
the ones privately owned by a user were not shown.

This was caused by the missing override of the 
listRepositories(final int pageSize) at GHMyself
that caused the GHPerson implementation to invoked.

The GHPerson version uses the /users/:org/repos?per_page=x
URL which *works fine* for organisations but unfortunately
*does not return* private repositories for users.

IMHO GitHub API are quite inconsistent form this 
point of view, but they are documented in this way
so that work (inconsistently) as designed.
    @lucamilanesio
    lucamilanesio committed Jul 3, 2014
    Configuration menu
    Copy the full SHA
    449909b View commit details
    Browse the repository at this point in the history