Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new options
custom_container
to build PR in the CI in a custom container. By default, workflow runs inside"huggingface/transformers-doc-builder"
which is the container needed fortransformers
and that has all dependencies like torch, tensorflow, etc. However, it takes quite some time (>2min) to initialize the container in the CI given its size. In theory, most libraries don't need this container so we should be able to bypass this step and run directly onubuntu:latest
.This PR is related to huggingface/huggingface_hub#2140 in which I tested the idea.
As discussed on slack (internal), plan is:
custom_container: ""
) on several repos, including huggingface_hub (already done), datasets, diffusers, hub-docs, etc.custom_container: "huggingface/transformers-doc-builder"
in their CI. This should not change anything since it is the default value for now.""
This way we should be able to make the transition between "all of them use transformers image" to "most of them use a bare ubuntu" without a breaking change in the process.