Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to speed up docs #2140

Closed
wants to merge 17 commits into from
Closed

Tests to speed up docs #2140

wants to merge 17 commits into from

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 21, 2024

Related to huggingface/doc-builder#487 and internal slack thread. There is now a custom_container option when building docs in CI. When set to "" (instead of "huggingface/transformers-doc-builder" by default), we don't run the CI inside a container, therefore saving ~2min of download time. The plan is to test disabling the transformers container on a few "big" repo and if everything works correctly, we will stop making it the default container. More details on huggingface/doc-builder#487.

cc @mishig25

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin Wauplin changed the title wip Tests to speed up docs Mar 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (3252e27) to head (3108fdb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
+ Coverage   82.70%   82.81%   +0.10%     
==========================================
  Files         103      103              
  Lines        9628     9670      +42     
==========================================
+ Hits         7963     8008      +45     
+ Misses       1665     1662       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wauplin Wauplin marked this pull request as ready for review March 25, 2024 17:08
@Wauplin
Copy link
Contributor Author

Wauplin commented Apr 30, 2024

Dropping this now that huggingface/doc-builder#487 has been successfully merged :)

@Wauplin Wauplin closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants