Avoid class attribute _keep_in_fp32_modules being modified #27867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
changed the title
ydshieh
commented
Dec 6, 2023
| # Overwrite the class attribute to make it an instance attribute, so models like | ||
| # `InstructBlipForConditionalGeneration` can dynamically update it without modifying the class attribute | ||
| # when a different component (e.g. language_model) is used. | ||
| self._keep_in_fp32_modules = copy.copy(self.__class__._keep_in_fp32_modules) |
There was a problem hiding this comment.
We can't do self._keep_in_fp32_modules = self.__class__._keep_in_fp32_modules , otherwise the in place operation like extend will modify the same object.
ArthurZucker
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Another approach to #26433. Fix #25910