Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid class attribute _keep_in_fp32_modules being modified #27867

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Avoid class attribute _keep_in_fp32_modules being modified #27867

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7c66c9
fix
ydshieh Dec 6, 2023
94eed4e
fix
ydshieh Dec 6, 2023
3257b4c
fix
ydshieh Dec 6, 2023
b0adb15
fix
ydshieh Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
import collections
import copy
import functools
import gc
import importlib.metadata
Expand Down Expand Up @@ -1154,6 +1155,10 @@ def __init__(self, config: PretrainedConfig, *inputs, **kwargs):
self.name_or_path = config.name_or_path
self.warnings_issued = {}
self.generation_config = GenerationConfig.from_model_config(config) if self.can_generate() else None
# Overwrite the class attribute to make it an instance attribute, so models like
# `InstructBlipForConditionalGeneration` can dynamically update it without modifying the class attribute
# when a different component (e.g. language_model) is used.
self._keep_in_fp32_modules = copy.copy(self.__class__._keep_in_fp32_modules)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do self._keep_in_fp32_modules = self.__class__._keep_in_fp32_modules , otherwise the in place operation like extend will modify the same object.


def post_init(self):
"""
Expand Down
Loading