Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hum 40 address validation and debounce for Search escrow address #2661

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

KacperKoza343
Copy link
Contributor

@KacperKoza343 KacperKoza343 commented Oct 21, 2024

tasks HUM-40

Copy link

vercel bot commented Oct 21, 2024

@KacperKoza343 is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

This was referenced Oct 22, 2024
@KacperKoza343 KacperKoza343 changed the title Hum 40 hum 50 Hum 40 Oct 25, 2024
@KacperKoza343 KacperKoza343 changed the title Hum 40 Hum 40 address validation and debounce for Search escrow address Oct 25, 2024
@dnechay dnechay self-requested a review October 25, 2024 15:03
Copy link

@dnechay dnechay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

One non-blocking question

});

const debouncedUpdater = debounce((value: string) => {
if (updater) updater(value);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of doing this check we make updated required parameter for this, wdyt?

@dnechay dnechay self-requested a review October 25, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants