Hum 50 #2667
Hum 50 #2667
Conversation
|
@KacperKoza343 is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Approach lgtm, 2 points
- We should apply the same logic to oracles table queries (now you can spawn multiple requests by selecting in job type filter)
- Make sure your git history is clean before we merge
- Do we need this PR? It seems to be part of Hum 40 address validation and debounce for Search escrow address #2661
| @@ -99,10 +102,18 @@ export function createFetcher(defaultFetcherConfig?: { | |||
| : fetcherOptions.options; | |||
| if (fetcherOptions.authenticated) { | |||
| fetcherOptionsWithDefaults = appendHeader(fetcherOptionsWithDefaults, { | |||
| Authorization: `Bearer ${browserAuthProvider.getAccessToken() ?? ''}`, | |||
| // eslint-disable-next-line @typescript-eslint/restrict-template-expressions | |||
There was a problem hiding this comment.
Wouldn't it be better if we change the rule globally in order to allow not only strings, but also booleans, numbers and null/undefined?
There was a problem hiding this comment.
I agree with that
There was a problem hiding this comment.
@KacperKoza343 could you please do it in this PR?
|
That's true, but you always can comment some code in your working branch or alter git history for testing purpose. If we keep two separate PRs and merge this one first - it will create unnecessary difficulties for you in the second one with resolving conflicts. Up to you in the end |
Yes, I will add new signal here |
task HUM-50