-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hum 50 #2667
base: develop
Are you sure you want to change the base?
Hum 50 #2667
Conversation
@KacperKoza343 is attempting to deploy a commit to the HUMAN Protocol Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approach lgtm, 2 points
- We should apply the same logic to oracles table queries (now you can spawn multiple requests by selecting in job type filter)
- Make sure your git history is clean before we merge
- Do we need this PR? It seems to be part of Hum 40 address validation and debounce for Search escrow address #2661
@@ -99,10 +102,18 @@ export function createFetcher(defaultFetcherConfig?: { | |||
: fetcherOptions.options; | |||
if (fetcherOptions.authenticated) { | |||
fetcherOptionsWithDefaults = appendHeader(fetcherOptionsWithDefaults, { | |||
Authorization: `Bearer ${browserAuthProvider.getAccessToken() ?? ''}`, | |||
// eslint-disable-next-line @typescript-eslint/restrict-template-expressions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better if we change the rule globally in order to allow not only strings, but also booleans, numbers and null/undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KacperKoza343 could you please do it in this PR?
|
That's true, but you always can comment some code in your working branch or alter git history for testing purpose. If we keep two separate PRs and merge this one first - it will create unnecessary difficulties for you in the second one with resolving conflicts. Up to you in the end |
Yes, I will add new signal here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one comment about commented linter
task HUM-50