Depth stream 37 0 2055 0 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Layout the rendering areas in grid. 2. Shrink the video to match the screen size. BUG=None TEST=Run the test on peach-pit Review URL: https://codereview.chromium.org/298123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277364 0039d316-1c4b-4281-b951-d872f2087c98
…sts. BUG=None TEST=None [email protected] Review URL: https://codereview.chromium.org/338733002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277365 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383427 [email protected] Review URL: https://codereview.chromium.org/329373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277366 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277367 0039d316-1c4b-4281-b951-d872f2087c98
BUG=378621 TEST=successful build Review URL: https://codereview.chromium.org/327323006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277368 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176166:176166&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/337973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277369 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277370 0039d316-1c4b-4281-b951-d872f2087c98
The managed bookmarks folder can have a different name depending on the signed-in status of the user. This change makes the context menu that hides this folder follow the folder's name. Also fixed a glitch where the folder name would not update if configured both via cloud policy and platform policy. BUG=49598 Review URL: https://codereview.chromium.org/332443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277371 0039d316-1c4b-4281-b951-d872f2087c98
This CL seems to cause perf bot failure. The log said nacl_helper-data size gained exceeds expectation. http://build.chromium.org/p/chromium/builders/Linux/builds/50560 https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper-data&rev=277212&checked=core > [PPAPI] Compositor API implementation. > > Implement the compositor API which allows a plugin to combine different sources of visual data efficiently, such as PPB_ImageData and OpengGL texture. > > API Proposal http://goo.gl/V7xcu3 > > BUG=374383 > > Review URL: https://codereview.chromium.org/298023004 [email protected] Review URL: https://codereview.chromium.org/331123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277372 0039d316-1c4b-4281-b951-d872f2087c98
This adds a check to PepperPluginInstanceImpl::DidDataFromWebURLResponse to avoid calling the instances HandleDocumentLoad function if the plugin instance is deleted before the function gets called. It also adds a check to PepperURLLoaderHost::Close to avoid trying to access an instance that has already been destroyed. A TODO is also added because the behavior of PepperURLLoaderHost::Close is incorrect. BUG=384197,372548 Review URL: https://codereview.chromium.org/335463006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277373 0039d316-1c4b-4281-b951-d872f2087c98
Previously V8VarConverter::FromV8Value would always complete asynchronously (we would always post a task to the message loop to run the callback). However, this adds latency to the transmission of postMessage'd messages. It also has the unfortunate consequence that posted messages can arrive out of order with other messages (such as view changes). We should attempt to convert synchronously if possible and only resort to asynchronous conversion if needed. BUG=367896 Review URL: https://codereview.chromium.org/331593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277374 0039d316-1c4b-4281-b951-d872f2087c98
https://skia.googlesource.com/skia/+log/09b187c9bdc0bb35f455d2df2f0b6a8303f8114a..851eabe56424147069b9018ec91f6b528d4c09db [email protected] BUG= Review URL: https://codereview.chromium.org/338003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277375 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277376 0039d316-1c4b-4281-b951-d872f2087c98
…odereview.chromium.org/336653002/) Reason for revert: THis CL breaks several WebRTC bots. See e.g. http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Tester. [32/32] WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 (TIMED OUT) 2 tests timed out: WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0 WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1 Original issue's description: > Revert: Per navigation sticky media permissions. > This CL re-enables the same behavior for getUserMedia prompts as it was in M35. > The reason for this is because there was a change of hearts at the standards level about this. > More information in the issue. > > BUG=269719 > COLLABORATOR=xians > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276974 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=269719 Review URL: https://codereview.chromium.org/338753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277377 0039d316-1c4b-4281-b951-d872f2087c98
Temporarily disabling the test AppListControllerAppInfoDialogBrowserTest.DoShowAppInfoFlow as it is suspected to be flaky. Will investigate as part of bug. BUG=378251 Review URL: https://codereview.chromium.org/338003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277378 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176166:176170&mode=html [email protected] BUG= Review URL: https://codereview.chromium.org/339503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277379 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277380 0039d316-1c4b-4281-b951-d872f2087c98
BUG=384219 TEST=run the test Review URL: https://codereview.chromium.org/332873008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277381 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383234 TEST=manually tested Review URL: https://codereview.chromium.org/333203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277384 0039d316-1c4b-4281-b951-d872f2087c98
…eForCreateFolder BUG=344769 Review URL: https://codereview.chromium.org/336713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277385 0039d316-1c4b-4281-b951-d872f2087c98
A table is added for MP4 mime types and their corresponding containers H.264 codecs vary according to the profile version. These are represented by hexadecimal numbers (RFC6381). These vary across platforms, hence a definite "probably" cannot be given for canPlayType query. The best we can say is a "maybe" if the codec is RFC compliant. New behaviour of the browser will be audio/mp4 -> avc1/ avc1./ avc1.4D4001 = "" audio/mp4 -> mp4a/ mp4a.40/ mp4a.40.2 = "maybe" audio/mp4 -> mp4a./ mp4a.50/ mp4a.40. = "" video/mp4 -> avc1/avc1.4D4001/ = "maybe" video/mp4 -> avc1./ avc1.NonHexDigits = "" (similar for mp4a and avc3) BUG=53193 TEST=out/Release/content_browsertests --gtest_filter=MediaCanPlayType* Review URL: https://codereview.chromium.org/254983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277386 0039d316-1c4b-4281-b951-d872f2087c98
This fixes the calculation for the threshhold we use to calculate whether the graphics context needs to be resized. There isn't a correctness issue here, as the context will always be large enough but it results in resizing more than necessary. This example demonstrates the issue: -If the plugin size was 100 x 100, we would set the context size to 100+kBufferSize x 100+kBufferSize. -If the plugin was then resized to 90x90 we would check to see if the plugin size is smaller than (100+kBufferSize)-kBufferSize x (100+kBufferSize)-kBufferSize which is equal to 100 x 100. -But we really intend to check whether it is smaller than 100-kBufferSize x 100-kBufferSize Thus we should check whether the plugin is smaller than the (current context size) - 2*kBufferSize which is kBufferSize less than the plugin size when the context size was last computed. BUG=303491 Review URL: https://codereview.chromium.org/337443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277387 0039d316-1c4b-4281-b951-d872f2087c98
We have the separated video player, and we don't need to play videos in the gallery. BUG=251702 TEST=None Review URL: https://codereview.chromium.org/337893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277388 0039d316-1c4b-4281-b951-d872f2087c98
SwipeAction. SwipeAction now also able to perform swipe on element with selector and text (not just element_function). SwipeAction no longer accepts attributes and instead accept normal parameters. Added unit tests. BUG=361809 Review URL: https://codereview.chromium.org/337643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277389 0039d316-1c4b-4281-b951-d872f2087c98
Fixes ASAN component build after r277201. [email protected] Review URL: https://codereview.chromium.org/339543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277390 0039d316-1c4b-4281-b951-d872f2087c98
Add a EVENT_TRACE to initialization and finalization of SyncTaskToken to measure the time elapsed for SyncFS. BUG=344769 Review URL: https://codereview.chromium.org/337073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277391 0039d316-1c4b-4281-b951-d872f2087c98
BUG=383738 TEST=run the test Review URL: https://codereview.chromium.org/330003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277392 0039d316-1c4b-4281-b951-d872f2087c98
…etection, when database row has non-empty realm, assume autofill::PasswordForm::SCHEME_BASIC. BUG=375158 Review URL: https://codereview.chromium.org/306123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277393 0039d316-1c4b-4281-b951-d872f2087c98
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176171:176183&mode=html [email protected],[email protected] BUG= Review URL: https://codereview.chromium.org/334193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277394 0039d316-1c4b-4281-b951-d872f2087c98
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277395 0039d316-1c4b-4281-b951-d872f2087c98
huningxin
pushed a commit
that referenced
this pull request
Nov 28, 2014
…ot scripts. (patchset #1 id:1 of https://codereview.chromium.org/609713002/) Reason for revert: That revert was apparrently a really bad idea. Now all the bots are failing. Reverting the revert and hoping that will bring us back to one failing bot. Original issue's description: > Revert of Do not call run_webkit_tests.py in android buildbot scripts. (patchset #2 id:20001 of https://codereview.chromium.org/603563002/) > > Reason for revert: > Makes the webkit_lint step fail on android bots: > > @@@BUILD_STEP webkit_lint@@@ > > /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > Usage: lint-test-expectations [options] > > lint-test-expectations: error: no such option: --target > < /b/build/slave/WebKit_Android__Nexus4_/build/src/third_party/WebKit/Tools/Scripts/lint-test-expectations --target Release > ERROR: process exited with code 2 > @@@STEP_FAILURE@@@ > > Original issue's description: > > Do not call run_webkit_tests.py in android buildbot scripts. > > > > Replace its usage by lint-test-expectations and run-webkit-tests, both > > scripts found in third_party/WebKit/Tools/Scripts. > > > > BUG=338338 > > TEST=None > > [email protected],[email protected] > > > > Committed: https://crrev.com/9c330bf94b161a4a19b1bcccb33b169843b4fd10 > > Cr-Commit-Position: refs/heads/master@{#296883} > > [email protected],[email protected],[email protected] > NOTREECHECKS=true > NOTRY=true > BUG=338338 > > Committed: https://crrev.com/ce392c3ccf021a094e21ffa3ca3babeb313b4821 > Cr-Commit-Position: refs/heads/master@{#296892} [email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=338338 Review URL: https://codereview.chromium.org/598083006 Cr-Commit-Position: refs/heads/master@{#296893}
huningxin
pushed a commit
that referenced
this pull request
Nov 28, 2014
… of https://codereview.chromium.org/600833002/) Reason for revert: Breaks Android waterfall. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29 Original issue's description: > Start building ui_base_unittests targets. > > This is in preparation for updating the buildbot code. First we need to > make sure we build those targets, otherwise buildbot will fail. > > BUG=331829,373148,299841,103304 > TEST=None > [email protected],[email protected] > > Committed: https://crrev.com/430fc906824927713d5a318afb50654e95b699b0 > Cr-Commit-Position: refs/heads/master@{#296877} [email protected],[email protected],[email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=331829,373148,299841,103304 Review URL: https://codereview.chromium.org/603413002 Cr-Commit-Position: refs/heads/master@{#296903}
huningxin
pushed a commit
that referenced
this pull request
Nov 28, 2014
…dden. (patchset #1 id:1 of https://codereview.chromium.org/502413004/) Reason for revert: Broke certificate info positioning when switching tabs (http://crbug.com/419371). I will need to come up with a better fix for this, but it looks complicated and that bug is a M39 stable blocker so reverting this first. Original issue's description: > Mac: Update sheet position when bookmark bar is shown or hidden. > > In r272421, I changed sheet repositioning on window resize to be based on > NSWindowDidResizeNotification instead of NSViewFrameDidChangeNotification > because it tracks window resizing much more smoothly. > > That caused this problem where if the browser window is vertically maximized > (or is in fullscreen), the window size does not change when the bookmark bar > is shown or hidden. > > The old code has a different bug however. If the browser window is not > vertically maximized, showing or hiding the bookmark bar does not change the > browser content view's frame. It moves up or down to follow the window resize > but its frame relative to its superview remains the same. > > I settled for adding code to explicitly update the sheet's position when the > bookmark bar is shown or hidden. > > BUG=407509 > > Committed: https://crrev.com/5648b809d1c50e3de754b96abe7cf2b60150ff4d > Cr-Commit-Position: refs/heads/master@{#292421} [email protected] BUG=407509 Review URL: https://codereview.chromium.org/653733002 Cr-Commit-Position: refs/heads/master@{#299391} (cherry picked from commit 92af67f) Review URL: https://codereview.chromium.org/644873005 Cr-Commit-Position: refs/branch-heads/2171@{crosswalk-project#193} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
huningxin
pushed a commit
that referenced
this pull request
Dec 10, 2015
…document. (patchset #1 id:1 of https://codereview.chromium.org/1139033002/) (Merging to M44.) Reason for revert: Caused a large spike in crashes across several bugs: https://crbug.com/426658 https://crbug.com/488382 https://crbug.com/488421 https://crbug.com/488434 https://crbug.com/488470 Original issue's description: > Remove a HistoryNode's children when it navigates to a new document. > > When a reload occurs (or other inert commits), we leave the history tree alone. However, if iframes are dynamically created, we end up with both the old iframes and the new iframes in the history tree, and we never prune them. Instead, if a different-document inert commit occurs, remove the committing node's children, since the corresponding frames are no longer in the frame tree. > > BUG=485385 > > Committed: https://crrev.com/9f3e29c910ce2c2a9c3a60b2675db59d95b8ad3a > Cr-Commit-Position: refs/heads/master@{#329763} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485385 Review URL: https://codereview.chromium.org/1148473002 Cr-Commit-Position: refs/heads/master@{#330435} (cherry picked from commit 5c8a902) Review URL: https://codereview.chromium.org/1131383005 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#15} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin
pushed a commit
that referenced
this pull request
Dec 10, 2015
ChromeSRMDelegate should not be reading the WebContents* back from WebContentsObserver after it has explicitly set to observe nullptr WebContents. This was introduced by my earlier CL: r330213, I never tested the feature from NTP. [email protected] BUG=489182, 489157 Test=1) From new tab page, click on the mic beside search box, feed it some search query, it should not crash chrome. 2) Similar to step #1, but before the query completes, close the tab, observe no crash. Review URL: https://codereview.chromium.org/1134773004 Cr-Commit-Position: refs/heads/master@{#330784} (cherry picked from commit ada65a7) Review URL: https://codereview.chromium.org/1149763008 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#59} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin
pushed a commit
that referenced
this pull request
Dec 10, 2015
…e instead of Timeticks. (patchset #1 id:140001 of https://codereview.chromium.org/1140083004/) Reason for revert: Reverting for georgesak@ (his committer access hasn't propagated yet it looks like). After discussion with sky@, decided to keep TimeTicks. Original issue's description: > Change WebContents::last_active_time_ to Time instead of Timeticks. > > For context, last_active_time_ is going to be used by session restore to order the loading of background tabs using MRU. In order for this to be robust, last_active_time_ must be saved and restore between sessions. Timeticks cannot be reliably restored as it's dependent on the current OS session. MRU code for session restore is being implemented in https://codereview.chromium.org/1131373003 > > Notes: > - In dev tools, replaced "activity" with "active" for consistency > - In OomPriorityManagerTest.Comparator, initialized last_active_time for all tabs, as this is necessary with Time (a default TimeTicks can go back in time, not the case with Time). > > BUG=472772 > > Committed: https://crrev.com/041ef9c96d9a5b6f206a24385b0e6e4b3dbf9f20 > Cr-Commit-Position: refs/heads/master@{#330029} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472772 Review URL: https://codereview.chromium.org/1145233002 Cr-Commit-Position: refs/heads/master@{#330778} (cherry picked from commit 0dccfef) Review URL: https://codereview.chromium.org/1153083003 Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#217} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin
pushed a commit
that referenced
this pull request
Dec 10, 2015
…tanceState (patchset #1 id:1 of https://codereview.chromium.org/1143933005/) Reason for revert: Red herring; the actual reason for "non-working" "sign-out" and "go incognito" buttons was incorrect (absent) initialization of upstream-split parts of AccountManagementFragment. Original issue's description: > Revert of Ignore account management actions after onSaveInstanceState (patchset #1 id:1 of https://codereview.chromium.org/1144113005/) > > Reason for revert: > Nopes, didn't help, but made things worse: running another activity renders the dialog fragment unusable. > > Original issue's description: > > Ignore account management actions after onSaveInstanceState > > > > BUG=490629 > > > > Committed: https://crrev.com/01ef47a29ff30d2edf7e46fe70000cf5a54a4f2b > > Cr-Commit-Position: refs/heads/master@{#331909} > > [email protected] > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=490629 > > Committed: https://crrev.com/c6f70ebd508e0245eae4ecc026ef5316a617493e > Cr-Commit-Position: refs/heads/master@{#332067} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490629 Review URL: https://codereview.chromium.org/1171763002 Cr-Commit-Position: refs/heads/master@{#333344} (cherry picked from commit 4e82fd7) Review URL: https://codereview.chromium.org/1173473002. Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#251} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin
pushed a commit
that referenced
this pull request
Dec 10, 2015
…that wasn't typed) Revert "Revert of Don't create a sync node when updating an URL that wasn't typed. (patchset #1 id:1 of https://codereview.chromium.org/1126633005/)" This reverts commit ebb1803. Original CL: https://codereview.chromium.org/1126633005 [email protected] BUG=496855 Review URL: https://codereview.chromium.org/1156583006 Cr-Commit-Position: refs/heads/master@{#332960} (cherry picked from commit 4414915) [email protected] Review URL: https://codereview.chromium.org/1175103002. Cr-Commit-Position: refs/branch-heads/2403@{crosswalk-project#268} Cr-Branched-From: f54b809-refs/heads/master@{#330231}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
Previously, any time the webview plugin needed to schedule animation, it dirtied layout in the containing frame. This was because it used to be the case that LayoutEmbeddedObject would run the webview plugin's lifecycle as part of layout. However, this is not right, for two reasons: 1. A lifecycle update for later phases may be needed for the plugin due to changes in the parent, even if layout is not dirty. This can lead to not running the webview lifecyle in some cases. https://codereview.chromium.org/1708923002 fixed this by always running the lifecycle of the webview plugin when the parent does. 2. Animation is scheduled for two reasons: lifecyle update, and actual animations, such as issuing resize events to script. It is valid to queue up async script events during a lifecycle update. (In one case in the referenced bug, FrameView:: sendResizeEventIfNeeded does this when it notices that layout changed the size of the frame). This CL fixes cases such as that, and builds up on the one fixing issue #1, by scheduling animation of the parent frame but not dirtying layout. BUG=590856 Review URL: https://codereview.chromium.org/1774653002 Cr-Commit-Position: refs/heads/master@{#379694} (cherry picked from commit 78ea22a) Review URL: https://codereview.chromium.org/1777563003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#137} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…set #1 id:1 of https://codereview.chromium.org/1782563002/ ) Reason for revert: Merged incorrectly. Will revert for now and remerge. Original issue's description: > Takeover MT initiated animations from the compositor > > This is a followup CL to https://crrev.com/1734063003/. It finishes a > MT initiated animation running on the compositor, on the MT. > > BUG=581875 > > Review URL: https://codereview.chromium.org/1770443002 > > Cr-Commit-Position: refs/heads/master@{#379868} > (cherry picked from commit d0eaee2) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581875 Review URL: https://codereview.chromium.org/1778223002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#166} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…heets is true. (patchset #1 id:1 of https://codereview.chromium.org/1827043003/ ) Reason for revert: Build failed. The branch was before we renamed the getters from property to getProperty. Original issue's description: > Disable subsequence caching when didLayoutWithPendingStylesheets is true. > > BUG=593758 > > Review URL: https://codereview.chromium.org/1823353003 > > Cr-Commit-Position: refs/heads/master@{#382791} > (cherry picked from commit 27c2539) > > Committed: https://chromium.googlesource.com/chromium/src/+/91283f70477be7d059454b89fb7839dbd465130d [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593758 Review URL: https://codereview.chromium.org/1833003002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#382} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…id:1 of https://codereview.chromium.org/1828703006/ ) Reason for revert: Doesn't compile on m50 branch Original issue's description: > Android: fix memory regression on svelte device > > Virtualized GL contexts were being disabled for > some non-full screen video due to the attribute > |alpha| used for context creation requests made in > RenderWidget/RenderThreadImp was true. > > This CL check the surface type (on/off) to disable > virtualized GL only for onscreen surfaces whose > format doesn't match the default. > > BUG=594083, 591100 > > Review URL: https://codereview.chromium.org/1818303002 > > Cr-Commit-Position: refs/heads/master@{#383179} > (cherry picked from commit 5c3c0ed) > > NOTRY=true > NOPRESUBMIT=true [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594083, 591100 Review URL: https://codereview.chromium.org/1840583002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#394} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
Repro steps: 1.) Turn on "Don't keep activities" 2.) Navigate to a test form site: https://www.cs.tut.fi/~jkorpela/forms/testing.html 3.) Submit POST form 4.) Refresh 5.) Hit the home button (causing the activity to be destroyed per #1 It crashes in the destruction path as the fragment manager has been destroyed. Add a safety check to prevent the crash. BUG=598196 Review URL: https://codereview.chromium.org/1836053002 Cr-Commit-Position: refs/heads/master@{#383574} Review URL: https://codereview.chromium.org/1837073002 . Cr-Commit-Position: refs/branch-heads/2661@{#409} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…:1 of https://codereview.chromium.org/1836093003/ ) Reason for revert: Didn't build on M50. Original issue's description: > Remove secondary player from Media Sessions > > When we switch Android media players, for cast, we no longer want audio > focus changes associated with old player to take effect. To handle this > remove the old player from the Media Sessions. > > The new player is responsible for adding itself to the Media Sessions if > it needs to. The remote player doesn't need to, and, after stopping casting > the local player will do so when the user presses play. > > BUG=595373 > > Review URL: https://codereview.chromium.org/1823983002 > > Cr-Commit-Position: refs/heads/master@{#382613} > (cherry picked from commit 4bee90c) > > Committed: https://chromium.googlesource.com/chromium/src/+/3ad63a558b2fbe889d02eeffe2f664955bfc9f07 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=595373 Review URL: https://codereview.chromium.org/1842763003 Cr-Commit-Position: refs/branch-heads/2661@{#421} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…it. (patchset #1 id:1 of https://codereview.chromium.org/1861933002/ ) Reason for revert: Unittest doesn't compile on the branch. Need to reland without the test. Original issue's description: > cc: Indicate that we've updated a tiling if we invalidated it. > > This patch ensures that we inform the caller that the tiling was updated > if it was invalidated since the last call to ComputeTilePriorityRects. > > This ensures that we don't bypass TileManager::PrepareTiles call. > > R=danakj, enne > BUG=593449 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Review URL: https://codereview.chromium.org/1841083004 > > Cr-Commit-Position: refs/heads/master@{#385020} > (cherry picked from commit 6ee1182) > > Committed: https://chromium.googlesource.com/chromium/src/+/36f9bcfa8392c4ceab6da93507af27b1b01fedd8 [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593449 Review URL: https://codereview.chromium.org/1864973006 Cr-Commit-Position: refs/branch-heads/2661@{#501} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…K/ACK frames/packets list need to be res… (patchset #1 id:1 of https://codereview.chromium.org/1875433002/ ) Reason for revert: This change needs to be slightly modified since M50 does not have the |received_later_frames| set. Original issue's description: > Reset NACK/ACK list when parsing a new RTCP packet. The NACK/ACK frames/packets list need to be reset before parsing each RTCP packet as the parser is shared by all RTCP packets on sender side. This caused the performance regression and potentially video freezing as well. > > BUG=600527 > > Review URL: https://codereview.chromium.org/1853253003 > > Cr-Commit-Position: refs/heads/master@{#385046} > (cherry picked from commit 411ea14) > > Committed: https://chromium.googlesource.com/chromium/src/+/e877754f597c1c2fa8ff411be0c2c6ade0cd6c9f [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=600527 Review URL: https://codereview.chromium.org/1869163002 Cr-Commit-Position: refs/branch-heads/2661@{#512} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…tchset #1 id:1 of https://codereview.chromium.org/1875363002/ ) Reason for revert: Appears to have broken PFQ for M50. Reverting at request of ketakid@. Original issue's description: > [Merge to M50] Enable bootstrapping feature by default. > > Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave. > > BUG=597039 > [email protected], [email protected], [email protected] > > Review URL: https://codereview.chromium.org/1829453002 > > Cr-Commit-Position: refs/heads/master@{#383764} > (cherry picked from commit cfe5984) > > Committed: https://chromium.googlesource.com/chromium/src/+/086d377e0758cfdf3976985616f3afaf9940f1a9 [email protected] NOPRESUBMIT=true NOTRY=true BUG=597039 Review URL: https://codereview.chromium.org/1887953002 Cr-Commit-Position: refs/branch-heads/2661@{#579} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
… of https://codereview.chromium.org/1918353002/ ) Reason for revert: Merge conflict unresolved Original issue's description: > Bug fix in sampling whitelisted download. > > BUG=553674 > > Review URL: https://codereview.chromium.org/1911543002 > > Cr-Commit-Position: refs/heads/master@{#388575} > (cherry picked from commit 2c43aa6) > > Committed: https://chromium.googlesource.com/chromium/src/+/6f3d958d78e964f8f73030dd0eeb49b82f98b162 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=553674 Review URL: https://codereview.chromium.org/1923033002 Cr-Commit-Position: refs/branch-heads/2661@{#632} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…ings, if: (1) user opted in extended rep… (patchset #1 id:1 of https://codereview.chromium.org/1920293002/ ) Reason for revert: merge conflict unresolved. Original issue's description: > Sample 1% of whitelisted downloads to still send download pings, if: (1) user opted in extended reporting (2) user not in incognito mode. > > CSD server side change will make sure always return "SAFE" for these sampled pings. > > This cl is patched from 1866033003 (reverted), with changes to address buildbot memory warnings on linux Valgrind Test and nparker's comments on previous CL. > > BUG=553674 > > Committed: https://crrev.com/4722e9b36cfbca7493d3e4f7e2242ac6b8f30a04 > Cr-Commit-Position: refs/heads/master@{#387968} > > patch from issue 1866033003 at patchset 370001 (http://crrev.com/1866033003#ps370001) > > Review URL: https://codereview.chromium.org/1898013002 > > Cr-Commit-Position: refs/heads/master@{#388325} > (cherry picked from commit 75389f5) > > Committed: https://chromium.googlesource.com/chromium/src/+/575419fe258c678c589e179c998581992886f89a TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=553674 Review URL: https://codereview.chromium.org/1921533006 Cr-Commit-Position: refs/branch-heads/2661@{#633} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…ubstring (patchset #1 id:1 of https://codereview.chromium.org/1919143005/ ) Reason for revert: Broke the mac stable builder: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20stable/builds/615 ----- Log output copied here for convenience: ../../third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp:33:10: fatal error: 'platform/fonts/CharacterRange.h' file not found #include "platform/fonts/CharacterRange.h" ^ 1 error generated. ninja: build stopped: subcommand failed. Original issue's description: > Fix InlineTextBox::characterWidths() not to measure every substring > > This patch changes InlineTextBox::characterWidths() to use > Font::individualCharacterRanges() rather than to measure every > substring of InlineTextBox. Measuring every substring without context > is very expensive and also is not correct. > > When dev tools have long strings without spaces such as minified JS and > accessbility is turned on, the measuring of substrings can almost hang > it up. > > Currently, WebAXObject::characterOffsets() is the only user of this > function. > > BUG=593679, 568032 > TEST=Existing tests cover, such as AutomationApiTest.BoundsForRange > > Review URL: https://codereview.chromium.org/1897853004 > > Cr-Commit-Position: refs/heads/master@{#388162} > (cherry picked from commit 11f1c68) > > Committed: https://chromium.googlesource.com/chromium/src/+/a3b71a920f64013793487faebeadc648c1a0774b [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=593679, 568032 Review-Url: https://codereview.chromium.org/1927703002 Cr-Commit-Position: refs/branch-heads/2661@{#644} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
… of https://codereview.chromium.org/1933333002/ ) Reason for revert: breaking build Original issue's description: > Bug fix in sampling whitelisted download. > > BUG=553674 > > Review URL: https://codereview.chromium.org/1911543002 > > Cr-Commit-Position: refs/heads/master@{#388575} > (cherry picked from commit 2c43aa6) > > Committed: https://chromium.googlesource.com/chromium/src/+/58147f61dd13f5cd511ff0e0f97c98bfd9558d26 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=553674 Review-Url: https://codereview.chromium.org/1940463002 Cr-Commit-Position: refs/branch-heads/2661@{#651} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
May 17, 2016
…ings, if: (1) user opted in extended rep… (patchset #1 id:1 of https://codereview.chromium.org/1927413003/ ) Reason for revert: breaking build Original issue's description: > Sample 1% of whitelisted downloads to still send download pings, if: (1) user opted in extended reporting (2) user not in incognito mode. > > CSD server side change will make sure always return "SAFE" for these sampled pings. > > This cl is patched from 1866033003 (reverted), with changes to address buildbot memory warnings on linux Valgrind Test and nparker's comments on previous CL. > > BUG=553674 > > Committed: https://crrev.com/4722e9b36cfbca7493d3e4f7e2242ac6b8f30a04 > Cr-Commit-Position: refs/heads/master@{#387968} > > patch from issue 1866033003 at patchset 370001 (http://crrev.com/1866033003#ps370001) > > Review URL: https://codereview.chromium.org/1898013002 > > Cr-Commit-Position: refs/heads/master@{#388325} > (cherry picked from commit 75389f5) > > Committed: https://chromium.googlesource.com/chromium/src/+/b69b50343677e01ac97a7418cc531f5042b3b37c TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=553674 Review-Url: https://codereview.chromium.org/1924203005 Cr-Commit-Position: refs/branch-heads/2661@{#652} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
that referenced
this pull request
Oct 9, 2016
…g a pre-finalizer (patchset #1 id:1 of https://codereview.chromium.org/1978183002/ ) Reason for revert: Per discussion in the crbug, we're going to revert these speculative fixes to remove unknowns from further root-cause analysis on the crashes. https://crbug.com/612084#c38 Original issue's description: > MediaStreamSource::setReadyState should not be called during a pre-finalizer > > This is a speculative fix for bug 612084. > MediaStreamSource::dispose calls content::MediaStreamSource's destructor, > which calls MediaStreamSource::RunStopCallbackAndEndStream(), > which calls MediaStreamSource::setReadyState, which dispatches events. > It should be avoided. > > BUG=612084 > > Committed: https://crrev.com/1d844dcc68432429c77a04916908121da9ef4ca2 > Cr-Commit-Position: refs/heads/master@{#393837} [email protected],[email protected],[email protected] BUG=612084 Review-Url: https://codereview.chromium.org/2003203002 Cr-Commit-Position: refs/heads/master@{#395474} (cherry picked from commit d8d744d) Review URL: https://codereview.chromium.org/2006973003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#31} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
huningxin
pushed a commit
that referenced
this pull request
Oct 9, 2016
…p to spec. (patchset #1 id:1 of https://codereview.chromium.org/2032143004/ ) Reason for revert: Broke the continuous build because of a missing symbol. https://chromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20beta/builds/3236/steps/compile/logs/stdio FAILED: obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=269902-1 -DENABLE_RLZ -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DMOJO_USE_SYSTEM_IMPL -DTOOLKIT_VIEWS=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DUSE_CUPS '-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"' -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DUSE_LIBPCI=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -Iobj/chrome/browser_ui.gen -Iobj/chrome/browser_ui.gen/chrome -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit/Source -Igen/chrome -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/dist/proto_gen -Igen/policy -Igen/components -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/zlib -Igen/ui/resources -Igen/content/app/resources/ -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/re2/src -I../../v8/include -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -Igen/ui/views/resources -I../../third_party/libaddressinput/chromium/override -I../../third_party/libaddressinput/src/cpp/include -Igen/third_party/libaddressinput/ -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -O2 -gdwarf-2 -fvisibility=hidden -Werror -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wpartial-availability -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonnull -Wexit-time-destructors -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /b/build/slave/mac_beta/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang check-implicit-copy-ctors -fcolor-diagnostics -fno-strict-aliasing -fno-standalone-debug -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -c ../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm -o obj/chrome/browser/ui/cocoa/location_bar/browser_ui.location_bar_view_mac.o ../../chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:583:29: error: no member named 'GetSecureTextColor' in 'OmniboxViewMac' OmniboxViewMac::GetSecureTextColor(security_level, in_dark_mode); ~~~~~~~~~~~~~~~~^ Original issue's description: > [Mac][Material Design] Bring Omnibox stroke and MD colors up to spec. > > This cl changes the Omnibox's stroke in Incognito mode to match the > recent spec revisions made by sgabriel@. > > Changing to the new spec also required switching other MD colors to the > sRGB color space so that everything matched. The plan was to switch to > sRGB (which is correct - the calibrated space is not) eventually, but > to get the Omnibox to look right, now is the time. > > [email protected],[email protected] > BUG=613749 > > Review-Url: https://codereview.chromium.org/2013183003 > Cr-Commit-Position: refs/heads/master@{#396986} > (cherry picked from commit 7a7f2e3) > > Committed: https://chromium.googlesource.com/chromium/src/+/793018247051e845ad6754e0344f5f892349237f [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613749 Review-Url: https://codereview.chromium.org/2035153002 Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#208} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs: