Rebase current EIP-6110 prototype to Cancun #5752

ensi321 · 2023-08-04T08:32:33Z

PR description

This is to rebase the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification.
Changes include:

Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2
Rename deposits to depositReceipts in EnginePayloadParameter
Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3
Revamp the existed 6110 acceptance test

Fixed Issue(s)

github-actions · 2023-08-04T08:32:43Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

siladu

Seems mostly OK, will review once main is merged in.

Wonder if we need to filter the v6110 engine API methods out of https://github.com/hyperledger/besu/blob/main/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineExchangeCapabilities.java#L63-L65

Probably has no functional impact, it would probably just get ignored by the CLs but I'm not 100% sure.

siladu · 2023-09-07T04:33:39Z

...java/org/hyperledger/besu/tests/acceptance/jsonrpc/ExecutionEngineEip6110AcceptanceTest.java

 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;

 @RunWith(Parameterized.class)
-@Ignore("EIP-6110 is not yet implemented")
+// @Ignore("EIP-6110 is not yet implemented")


If this is OK to run then can we remove the comment completely?

siladu · 2023-09-07T04:36:39Z

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/RpcMethod.java

@@ -53,9 +53,11 @@ public enum RpcMethod {
  ENGINE_GET_PAYLOAD_V1("engine_getPayloadV1"),
  ENGINE_GET_PAYLOAD_V2("engine_getPayloadV2"),
  ENGINE_GET_PAYLOAD_V3("engine_getPayloadV3"),
+  ENGINE_GET_PAYLOAD_V6110("engine_getPayloadV6110"),


Good idea to keep this separate from the other well defined versions

.../src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/response/RpcErrorType.java

...hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineGetPayloadV6110Test.java

Signed-off-by: Navie Chan <[email protected]>

Signed-off-by: naviechan <[email protected]>

ensi321 · 2023-09-07T13:50:47Z

Seems mostly OK, will review once main is merged in.

Wonder if we need to filter the v6110 engine API methods out of https://github.com/hyperledger/besu/blob/main/ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineExchangeCapabilities.java#L63-L65

Probably has no functional impact, it would probably just get ignored by the CLs but I'm not 100% sure.

I think it's a good idea to filter them. CL devs might be confused about these extra endpoints

Signed-off-by: naviechan <[email protected]>

This reverts commit 7ecfbcd. Signed-off-by: naviechan <[email protected]>

Signed-off-by: naviechan <[email protected]>

siladu · 2023-10-02T08:58:27Z

...org/hyperledger/besu/ethereum/api/jsonrpc/internal/methods/engine/EngineNewPayloadV6110.java

+
+import io.vertx.core.Vertx;
+
+public class EngineNewPayloadV6110 extends EngineNewPayloadV3 {


What's the reason to extend V3 rather than AbstractEngineNewPayload?

Signed-off-by: Navie Chan <[email protected]>

Signed-off-by: naviechan <[email protected]>

Signed-off-by: Navie Chan <[email protected]>

Signed-off-by: naviechan <[email protected]>

siladu

LGTM

This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]>

This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

* Expose getSize to transaction interface (#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]>

* Expose getSize to transaction interface (hyperledger#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (hyperledger#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (hyperledger#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (hyperledger#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (hyperledger#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (hyperledger#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (hyperledger#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (hyperledger#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (hyperledger#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (hyperledger#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (hyperledger#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (hyperledger#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (hyperledger#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (hyperledger#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (hyperledger#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (hyperledger#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (hyperledger#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (hyperledger#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (hyperledger#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (hyperledger#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (hyperledger#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (hyperledger#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (hyperledger#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (hyperledger#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (hyperledger#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]>

ensi321 marked this pull request as draft August 4, 2023 08:47

ensi321 marked this pull request as ready for review August 10, 2023 06:46

ensi321 changed the title ~~[WIP] Rebase current EIP-6110 prototype to Cancun~~ Rebase current EIP-6110 prototype to Cancun Aug 10, 2023

siladu reviewed Sep 7, 2023

View reviewed changes

ensi321 added 17 commits September 7, 2023 18:51

Rename deposit to depositReceipts in payload param

2181e4a

Signed-off-by: Navie Chan <[email protected]>

Define engine_newPayloadV6110

9d624a4

Signed-off-by: Navie Chan <[email protected]>

Remove deposit related stuff on engine_getPayloadV2

4c0404f

Signed-off-by: Navie Chan <[email protected]>

Define engine_getPayloadV6110

27669f1

Signed-off-by: Navie Chan <[email protected]>

Fix conflict

2a9721f

Signed-off-by: Navie Chan <[email protected]>

Rebase 6110 acceptance to Cancun

7e31e64

Signed-off-by: Navie Chan <[email protected]>

Rename 6110 acceptance tests

21a402c

Signed-off-by: Navie Chan <[email protected]>

Update 6110 acceptance test

323178c

Signed-off-by: Navie Chan <[email protected]>

Update 6110 acceptance tests

a835f73

Signed-off-by: Navie Chan <[email protected]>

Payload related apis return UNSUPPORTED_FORK

ee77f08

Signed-off-by: Navie Chan <[email protected]>

SpotlessApply

3104224

Signed-off-by: Navie Chan <[email protected]>

Update 6110 Acceptance Test

c7896ef

Signed-off-by: Navie Chan <[email protected]>

Fix up Shanghai Acceptance Test

b61caf7

Signed-off-by: Navie Chan <[email protected]>

SpotlessApply

f57a8f9

Signed-off-by: Navie Chan <[email protected]>

Update EngineNewPayloadV6110Test

147094c

Signed-off-by: Navie Chan <[email protected]>

Spotless Apply

8c24aee

Signed-off-by: Navie Chan <[email protected]>

Update EngineGetPayloadV6110Test

ae07547

Signed-off-by: Navie Chan <[email protected]>

ensi321 force-pushed the eip-6110 branch from 617bc29 to ae07547 Compare September 7, 2023 10:59

ensi321 added 5 commits September 7, 2023 19:02

Fix conflict

89b4be5

Signed-off-by: Navie Chan <[email protected]>

Update EngineNewPayloadEIP6110Test

447230c

Signed-off-by: Navie Chan <[email protected]>

Update 6110 code from 4844

bdcf1ad

Signed-off-by: Navie Chan <[email protected]>

Update 6110 code from 4844

522f9de

Signed-off-by: Navie Chan <[email protected]>

Update hash

b40809b

Signed-off-by: naviechan <[email protected]>

Merge branch 'main' into eip-6110

aa85dad

Signed-off-by: naviechan <[email protected]>

ensi321 and others added 11 commits September 22, 2023 13:17

Merge branch 'main' into eip-6110

d75a5a1

Remove acceptance test due to active development of cancun

7ecfbcd

Signed-off-by: naviechan <[email protected]>

Fix conflict

1f2d834

Signed-off-by: naviechan <[email protected]>

Revert "Remove acceptance test due to active development of cancun"

ee45314

This reverts commit 7ecfbcd. Signed-off-by: naviechan <[email protected]>

Update 6110 acceptance test

091353a

Signed-off-by: naviechan <[email protected]>

Filter out V6110 endpoints in EngineExchangeCapabilities

6da4539

Signed-off-by: naviechan <[email protected]>

Merge branch 'main' into eip-6110

4414a64

Fix typo

87fc6ba

Signed-off-by: naviechan <[email protected]>

Update Tests

195e093

Signed-off-by: naviechan <[email protected]>

Merge remote-tracking branch 'origin/eip-6110' into eip-6110

121708c

SpotlessApply

1f9c22e

Signed-off-by: naviechan <[email protected]>

siladu reviewed Oct 2, 2023

View reviewed changes

ensi321 and others added 10 commits October 7, 2023 19:00

Address comment

4b01973

Signed-off-by: Navie Chan <[email protected]>

Merge branch 'main' into eip-6110

17a9813

Signed-off-by: naviechan <[email protected]>

Fix conflict

9a63728

Signed-off-by: Navie Chan <[email protected]>

Spotless Apply

61794e2

Signed-off-by: naviechan <[email protected]>

SpotlessApply

7d4343e

Signed-off-by: naviechan <[email protected]>

Update acceptance test

d9f4aac

Signed-off-by: naviechan <[email protected]>

Merge branch 'main' into eip-6110

dfd7619

Update acceptance test

fdcc9af

Signed-off-by: naviechan <[email protected]>

Merge branch 'main' into eip-6110

68e27b4

Merge branch 'main' into eip-6110

93b4630

siladu approved these changes Oct 10, 2023

View reviewed changes

siladu enabled auto-merge (squash) October 10, 2023 05:17

siladu merged commit 0536a18 into hyperledger:main Oct 10, 2023
19 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebase current EIP-6110 prototype to Cancun #5752

Rebase current EIP-6110 prototype to Cancun #5752

ensi321 commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited by ensi321

Loading

siladu left a comment

siladu Sep 7, 2023

siladu Sep 7, 2023

ensi321 commented Sep 7, 2023 •

edited

Loading

siladu Oct 2, 2023

siladu left a comment


		import io.vertx.core.Vertx;

		public class EngineNewPayloadV6110 extends EngineNewPayloadV3 {

Rebase current EIP-6110 prototype to Cancun #5752

Rebase current EIP-6110 prototype to Cancun #5752

Conversation

ensi321 commented Aug 4, 2023 • edited Loading

PR description

Fixed Issue(s)

github-actions bot commented Aug 4, 2023 • edited by ensi321 Loading

siladu left a comment

Choose a reason for hiding this comment

siladu Sep 7, 2023

Choose a reason for hiding this comment

siladu Sep 7, 2023

Choose a reason for hiding this comment

ensi321 commented Sep 7, 2023 • edited Loading

siladu Oct 2, 2023

Choose a reason for hiding this comment

siladu left a comment

Choose a reason for hiding this comment

ensi321 commented Aug 4, 2023 •

edited

Loading

github-actions bot commented Aug 4, 2023 •

edited by ensi321

Loading

ensi321 commented Sep 7, 2023 •

edited

Loading