Fcu v2 defer fork validation #6037

jflo · 2023-10-16T14:14:03Z

re-orders the validity checking and priority on forkchoice updated calls.

payloadAttributes needs to be validated apart from new head validity, so there are now two steps for checking so that we can fail differently if the head being built on is missing or irrelevant to the building payload.

github-actions · 2023-10-16T14:14:20Z

I thought about documentation and added the doc-change-required label to this PR if updates are required.
I thought about the changelog and included a changelog update if required.
If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

siladu · 2023-10-17T11:36:32Z

...edger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineForkchoiceUpdated.java

+  protected abstract Optional<JsonRpcErrorResponse> isPayloadAttributesValid(
+      final Object requestId,
+      final EnginePayloadAttributesParameter payloadAttributes,
+      final Optional<List<Withdrawal>> maybeWithdrawals);


Is it intentional that the withdrawals are validated separately from the rest of the payload attributes?

Yes, since the validator requires the parent header, we need to separate this out so we handle a syncing case prior.

In that case, think maybeWithdrawals can be removed from here as CodeQL suggests?

...edger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineForkchoiceUpdated.java

Signed-off-by: Justin Florentine <[email protected]>

* more error handling --------- Signed-off-by: Justin Florentine <[email protected]>

* more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]>

* Expose getSize to transaction interface (#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]>

* Expose getSize to transaction interface (hyperledger#5983) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add parameters to EVM library fluent API (hyperledger#5930) Add the ability to configure more parameters in the fluent API. Specifically contract address, coinbase, difficulty, mixHash/prevRandao, baseFee, block number, timestamp, gas limit, previous block hashes, and versioned hashes. Also create EVM forks parametrically instead of by a method name. Signed-off-by: Danno Ferrin <[email protected]> * Validation ordering (hyperledger#5986) * re-ordering error reporting priority * fixes fork checking on getPayload * adds acceptance test reproducing an issue where built blocks have proofs > txs * test coverage and fix for subtle re-org bug prior to proposals --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [4844] EngineNewPayload - Add Blob Count validation (hyperledger#5973) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Plugin Api - Add evaluateTransactionPostProcessing to TransactionSelector interface (hyperledger#5988) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Only use the builder to create transactions (hyperledger#5980) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Bump version to 23.10.1-SNAPSHOT (hyperledger#5990) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * hive tests explicitly attempt zero (hyperledger#5993) Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add plugins summary (hyperledger#5964) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Tests for GraphQL Cancun fields (hyperledger#5975) * Tests for GraphQL Cancun fields Add tests for GraphQL fields added to support cancun. Also, re-work test case inclusion code and update tests impacted by adding a new block to the chain. Signed-off-by: Danno Ferrin <[email protected]> * unneeded deltas in genesis file Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - Simplify plugin transaction selector interface to return object instead of list (hyperledger#5995) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Change Array Copying (hyperledger#5998) * Change Array Copying Change array copying by re-using arrays when safe. Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> * different bigint API Signed-off-by: Danno Ferrin <[email protected]> * straddle case Signed-off-by: Danno Ferrin <[email protected]> * less stack traces Signed-off-by: Danno Ferrin <[email protected]> * spotless Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Notify plugins when transaction is selected/rejected (hyperledger#6005) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Base EIP-6110 on top of Cancun (hyperledger#5752) This is to base the existed implementation of EIP-6110 from Shanghai to Cancun. As well, it updates the implementation according to the latest Engine API specification. Changes include: - Remove 6110 related changes from engine_newPayloadV2 and engine_getPayloadV2 - Rename deposits to depositReceipts in EnginePayloadParameter - Introduce engine_newPayloadV6110 and engine_getPayloadV6110 that are based on engine_newPayloadV3 and engine_getPayloadV3 - Revamp the existed 6110 acceptance test --- Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * add method to disable root verification for T8n and not Reference tests (hyperledger#6013) * add method to disable root verification for T8n and not Reference tests Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction detachedCopy to optimize txpool memory usage (hyperledger#5985) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Use existing Bytes48 for KZGCommitment and KZGProof (hyperledger#5997) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [Plugin API] - TransactionSelector - Send TransactionSelectionResult to the plugin when not transaction is not selected (hyperledger#6010) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update 23.10.0 changelog (hyperledger#6017) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Transaction Validation and Selection Plugin API update (hyperledger#6020) change Transaction Validation and Selection Plugin to make them more useful Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Force the use of jdk18 version of Bouncy Castle library (hyperledger#5748) This avoid that any dependency can include the jdk15 version in the distribution. Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * remove code duplication (hyperledger#6028) Signed-off-by: Stefan <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * docs: fix typo (hyperledger#6029) Signed-off-by: Sally MacFarlane <[email protected]> Co-authored-by: vuittont60 <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Standardize pubkey and public key naming in deposit (hyperledger#6012) --------- Signed-off-by: naviechan <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Optimize Eth_feeHistory RPC method (hyperledger#6011) * Add a cache to EthFeeHistory and improve rewards algorithm * cache the rewards by hash instead of block number * Add final on some fields Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Cache last blocks data (block headers, block bodies, transactions' receipts and total difficulty) (hyperledger#6009) * Add a flag --cache-last-blocks to cache last n blocks, The default value is 0 Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Sort only once rewardPercentiles instead of doing it for each block header (hyperledger#6035) Signed-off-by: Ameziane H <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * link to issue 5772 (hyperledger#6038) Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * fix incorrect argument passing in blockParameter of TraceCallMany class (hyperledger#6034) Signed-off-by: seongmin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix 23.10.0 Breaking Changes changelog entry (hyperledger#6040) Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Priority senders (hyperledger#5959) Signed-off-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fcu v2 defer fork validation (hyperledger#6037) * more error handling --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Fix typos (hyperledger#6036) Signed-off-by: shuoer86 <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Add X (Twitter) to README, Fix Roadmap Hyperlink (hyperledger#6047) * Add X to README, Fix Roadmap Hyperlink Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> * Update README Signed-off-by: David Cardenas <[email protected]> --------- Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Unsigned timestamps and blob gas used (hyperledger#6046) * lots of places an unsigned timestamp is a problem * adds unchecked annotations to OptionalUnsignedLong rpc parameter type --------- Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * [MINOR] ux improvements (hyperledger#6049) * log command line option that is affected * made plugins summary log part of config overview * check for null plugin context Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog release (hyperledger#6062) Signed-off-by: Gabriel-Trintinalia <[email protected]> * Dencun corner cases (hyperledger#6060) * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-22b78733e37a697fa8d1d8a02d2a87fe5ccea9cf67c34ce5e6311f024c14abd6L643-R738 Signed-off-by: Sally MacFarlane <[email protected]> * cherry pick changes from https://github.com/hyperledger/besu/pull/6054/files\#diff-61db834b59eae5ce5c438462505de1add8fa244deda830742060d15f668a9806R39-R44 Signed-off-by: Sally MacFarlane <[email protected]> * formatting Signed-off-by: Sally MacFarlane <[email protected]> * update the EIP-6110 acceptance tests Signed-off-by: Danno Ferrin <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Signed-off-by: Gabriel-Trintinalia <[email protected]> * Update changelog and gradle properties to next release Signed-off-by: Gabriel-Trintinalia <[email protected]> --------- Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Navie Chan <[email protected]> Signed-off-by: naviechan <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: Karim TAAM <[email protected]> Signed-off-by: Stefan <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Signed-off-by: Ameziane H <[email protected]> Signed-off-by: seongmin <[email protected]> Signed-off-by: shuoer86 <[email protected]> Signed-off-by: David Cardenas <[email protected]> Co-authored-by: Danno Ferrin <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: NC <[email protected]> Co-authored-by: matkt <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Co-authored-by: vuittont60 <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: seongmin <[email protected]> Co-authored-by: shuoer86 <[email protected]> Co-authored-by: David Cardenas <[email protected]> Signed-off-by: Justin Florentine <[email protected]>

* more error handling --------- Signed-off-by: Justin Florentine <[email protected]>

github-advanced-security bot found potential problems Oct 16, 2023

View reviewed changes

jflo enabled auto-merge (squash) October 16, 2023 17:05

Gabriel-Trintinalia disabled auto-merge October 16, 2023 23:01

Gabriel-Trintinalia requested changes Oct 16, 2023

View reviewed changes

...edger/besu/ethereum/api/jsonrpc/internal/methods/engine/AbstractEngineForkchoiceUpdated.java Outdated Show resolved Hide resolved

jflo added 5 commits October 17, 2023 07:45

more error handling

4ff5331

Signed-off-by: Justin Florentine <[email protected]>

more error handling

8128d4e

Signed-off-by: Justin Florentine <[email protected]>

moves syncing check after badblock check

6bc94a9

Signed-off-by: Justin Florentine <[email protected]>

spotless

395c33a

Signed-off-by: Justin Florentine <[email protected]>

check badblock before all else

7f0d334

Signed-off-by: Justin Florentine <[email protected]>

jflo force-pushed the fcuV2DeferForkValidation branch from 8d52b31 to 7f0d334 Compare October 17, 2023 15:37

jflo enabled auto-merge (squash) October 17, 2023 17:02

jflo requested review from Gabriel-Trintinalia and siladu October 17, 2023 17:02

jflo mentioned this pull request Oct 17, 2023

Unsigned timestamps and blob gas used #6046

Merged

Gabriel-Trintinalia approved these changes Oct 18, 2023

View reviewed changes

jflo merged commit a90e448 into hyperledger:main Oct 18, 2023
19 checks passed

Gabriel-Trintinalia pushed a commit to Gabriel-Trintinalia/besu that referenced this pull request Oct 20, 2023

Fcu v2 defer fork validation (hyperledger#6037)

a043a45

* more error handling --------- Signed-off-by: Justin Florentine <[email protected]>

NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023

Fcu v2 defer fork validation (hyperledger#6037)

9b126cd

* more error handling --------- Signed-off-by: Justin Florentine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fcu v2 defer fork validation #6037

Fcu v2 defer fork validation #6037

jflo commented Oct 16, 2023

github-actions bot commented Oct 16, 2023

siladu Oct 17, 2023

jflo Oct 17, 2023

siladu Oct 17, 2023 •

edited

Loading

Fcu v2 defer fork validation #6037

Fcu v2 defer fork validation #6037

Conversation

jflo commented Oct 16, 2023

github-actions bot commented Oct 16, 2023

siladu Oct 17, 2023

Choose a reason for hiding this comment

jflo Oct 17, 2023

Choose a reason for hiding this comment

siladu Oct 17, 2023 • edited Loading

Choose a reason for hiding this comment

siladu Oct 17, 2023 •

edited

Loading