Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump chai from 4.3.10 to 5.0.0 #1438

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2024

Bumps chai from 4.3.10 to 5.0.0.

Release notes

Sourced from chai's releases.

v5.0.0

BREAKING CHANGES

  • Chai now only supports EcmaScript Modules (ESM). This means your tests will need to either have import {...} from 'chai' or import('chai'). require('chai') will cause failures in nodejs. If you're using ESM and seeing failures, it may be due to a bundler or transpiler which is incorrectly converting import statements into require calls.
  • Dropped support for Internet Explorer.
  • Dropped support for NodeJS < 18.
  • Minimum supported browsers are now Firefox 100, Safari 14.1, Chrome 100, Edge 100. Support for browsers prior to these versions is "best effort" (bug reports on older browsers will be assessed individually and may be marked as wontfix).

What's Changed

New Contributors

Full Changelog: chaijs/chai@4.3.1...v5.0.0

v5.0.0-rc.0

The first Release Candidate of chai@v5 is here!

We've put out a few alpha versions and tested them out in various projects with good success. This RC includes all those changes plus any fixes that we've discovered since then.

Please try it out in your projects and let us know if you run into any issues so we can make fixes before version 5!

Thanks for using Chai 🙏🏻

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 1, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/chai-5.0.0 branch 4 times, most recently from 30cac60 to b3f2449 Compare January 2, 2024 10:01
@acelaya
Copy link
Contributor

acelaya commented Jan 2, 2024

Chai 5 has dropped support for common JS, and now it is full ESM.

I have tried a couple of ways to work around this, but it might be tricky.

  • Defining "type": "module" in package.json didn't work, because karma config is defined as CommonJS.
  • I tried refactoring karma config it into ESM, or renaming it to .cjs, but that only results in the same error again, as karma runs as CommonJS, but chai uses ESM syntax.
  • I tried replacing karma-chai (which has not been updated in 7 years) with karma-sinon-chai, which is a fork, but karma wasn't able to load the plugin for some reason. Didn't dig any deeper because this other plugin is still quite old.

We might be stuck with chai 4 as long as karma is not updated to support ESM.

@acelaya
Copy link
Contributor

acelaya commented Jan 2, 2024

The overall support of ESM in karma is discussed here karma-runner/karma#3677

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/chai-5.0.0 branch 7 times, most recently from aff6235 to 40c48c7 Compare January 8, 2024 12:37
Bumps [chai](https://github.com/chaijs/chai) from 4.3.10 to 5.0.0.
- [Release notes](https://github.com/chaijs/chai/releases)
- [Changelog](https://github.com/chaijs/chai/blob/main/History.md)
- [Commits](chaijs/chai@v4.3.10...v5.0.0)

---
updated-dependencies:
- dependency-name: chai
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/chai-5.0.0 branch from 40c48c7 to 59e60d1 Compare January 8, 2024 13:27
@acelaya
Copy link
Contributor

acelaya commented Jan 8, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 8, 2024

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@acelaya acelaya force-pushed the dependabot/npm_and_yarn/chai-5.0.0 branch from 96b413b to 8892e04 Compare January 8, 2024 15:19
@acelaya acelaya merged commit bfa8794 into main Jan 8, 2024
2 checks passed
@acelaya acelaya deleted the dependabot/npm_and_yarn/chai-5.0.0 branch January 8, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant