Update to chai 5 and remove karma-chai and karma-sinon #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertknight
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to chai 5, by following the same strategy as in hypothesis/frontend-shared#1418, hypothesis/browser-extension#1438 and hypothesis/h#8403
The changes are mainly focused on removing karma-chai and karma-sinon, as these are very outdated dependencies, which main purpose is globally exposing chai.assert and sinon to tests.
This PR does that manually in our bootstrap file, and removes the plugins altogether. That way, karma does not try to load chai as a CommonJS package, since v5 is only ESM.