Updates Server endpoints to v4 #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebrand Bluemix to IBM Cloud
* notify oauth server on logout * temporary server path * temporary server path * temporary server path * restore server path * restore server path * add log messge * change var names * change message severity
Development->master, various fixes and new Tokyo region
Development-> Master (rebranding)
sandmman
suggested changes
Feb 26, 2019
| @@ -24,5 +24,4 @@ | |||
| String getLocale(); | |||
There was a problem hiding this comment.
Gender can be removed as well
| return issuer.split("/")[2]; | ||
| } | ||
|
|
||
| private static String suffixFromRegion(String region) { |
There was a problem hiding this comment.
I think we will want to keep come sort of conversion from our old bluemix regions to new formats. One popular library we integrate with still uses the old branding
sandmman
approved these changes
Feb 26, 2019
gtaban
added a commit
that referenced
this pull request
Apr 5, 2019
rotembr
added a commit
that referenced
this pull request
Aug 21, 2019
* Update login widget section in readme (#133) * Updates Server endpoints to v4 (#135) * Changes SDK to use server v4 endpoints. Updates test cases * 1. Adds version and AZP validation 2. Updates iss validation * Issue 2439 (#138) Removed azp check * update version to 6 (#140) * Logout wrapper (#144) * added a wrapper logout function in AppID class which calls AppIDAuthorizationManager's logout * updated readme with the new AppID's logout wrapper
rotembr
added a commit
that referenced
this pull request
Aug 22, 2019
* Update login widget section in readme (#133) * Updates Server endpoints to v4 (#135) * Changes SDK to use server v4 endpoints. Updates test cases * 1. Adds version and AZP validation 2. Updates iss validation * Issue 2439 (#138) Removed azp check * update version to 6 (#140) * Logout wrapper (#144) * added a wrapper logout function in AppID class which calls AppIDAuthorizationManager's logout * updated readme with the new AppID's logout wrapper * added slack link (#147)
rotembr
added a commit
that referenced
this pull request
Aug 25, 2019
* Update login widget section in readme (#133) * Updates Server endpoints to v4 (#135) * Changes SDK to use server v4 endpoints. Updates test cases * 1. Adds version and AZP validation 2. Updates iss validation * Issue 2439 (#138) Removed azp check * update version to 6 (#140) * Logout wrapper (#144) * added a wrapper logout function in AppID class which calls AppIDAuthorizationManager's logout * updated readme with the new AppID's logout wrapper * added slack link (#147) * add some description to logout (#149) * update (#151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
audto be an arrayissvalidation (includes full path)azp