Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue23 uml #24

Merged
merged 7 commits into from
Dec 2, 2013
Merged

Issue23 uml #24

merged 7 commits into from
Dec 2, 2013

Conversation

rubenbaetens
Copy link
Contributor

UML-graph included as *.png in Fluid and referenced in information section.

@ghost ghost assigned mwetter Nov 22, 2013
This is for #24.
OpenModelica is using 3.2.1. Version 3.2.1 also fixes various uses of Modelica that are not according to the standard.
This is for #21. The image was moved to the Fluid/UsersGuide directory (to reflect the class in which it is used). The description has been moved to the section 'Implementation' as most users, except for developers, may not need this information.
@mwetter
Copy link
Contributor

mwetter commented Nov 22, 2013

Please address the following:

  • Include the source file needed to generate the class diagram. Put it in Resources/Images/Fluid/UsersGuide
  • Include the pdf (e.g., vector graphics) and delete the tif file. The tif file is rather large, and pdf would be smaller at higher quality.

Note that I reverted to use of MSL 3.2.1 as other revision are using 3.2.1, which fixes various non-standard uses of the Modelica language.

@ghost ghost assigned rubenbaetens Nov 22, 2013
rubenbaetens added a commit that referenced this pull request Dec 2, 2013
Merge Issue23 uml after including *.pdf and *.graphml
@rubenbaetens rubenbaetens merged commit 7fccf60 into master Dec 2, 2013
@rubenbaetens rubenbaetens deleted the issue23_uml branch December 2, 2013 08:10
mwetter pushed a commit that referenced this pull request Dec 8, 2016
mwetter pushed a commit that referenced this pull request Dec 8, 2016
mwetter pushed a commit that referenced this pull request Sep 15, 2021
Merging origin master into local master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants