Added a VerticalSlider widget. #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
reviewed
Dec 12, 2022
There was a problem hiding this comment.
Cool! Thank you.
I wonder if splitting the new logic completely into a new widget (e.g. VerticalSlider) would be a better approach, since the API guarantees around layout seem to be different between both orientations.
Duplication is not that much of a concern to me :)
Sure! Q: @hecrj do you want |
casperstorm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a
VerticalSlider- a duplicate ofSliderjust vertical.I've added an example, which can be run like so:
cargo run --package slider