Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical layout for segmented buttons, and cosmic example improvements #59

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

mmstick
Copy link
Member

@mmstick mmstick commented Dec 30, 2022

Screenshot from 2022-12-30 17-42-13

  • Adds Orientation enum for defining the vertical or horizontal layout of a widget.
  • Implements vertical orientation for the segmented button widget and its cosmic styles.
  • cosmic pages now have their own states and messages, and all controls are now mapped to unique states

@mmstick mmstick requested a review from a team December 30, 2022 16:43
@wash2 wash2 merged commit 0cea202 into master Jan 3, 2023
@13r0ck 13r0ck deleted the vertical branch January 3, 2023 05:19
@13r0ck
Copy link
Contributor

13r0ck commented Jan 3, 2023

Hector prefers duplicate widgets rather then an orientation enum. Maybe we should split this to stay consistant with upstream?
iced-rs/iced#1596 (review)

@mmstick
Copy link
Member Author

mmstick commented Jan 3, 2023

@13r0ck I'll try doing that then. GTK habits

@13r0ck
Copy link
Contributor

13r0ck commented Jan 3, 2023

lol no worries. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants