Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Configure kiwix to not display a searchbar and let ideascube handle it. #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mgautierfr
Copy link
Member

This PR correspond to the 590 one on ideascube ideascube/ideascube#590

@fheslouin
Copy link
Collaborator

How far are we from using this new feature ?

@mgautierfr
Copy link
Member Author

This is a bit on hold :/

It have been a lot of change on the kiwix side that somehow impact this feature:

  • We have rewritten all the build system of kiwix. (Split code in several repositories, add new master script to build everything, handle cross-compilation, ...) This works well but there is one missing feature for BSF : cross-compilation to ARM. Almost everything is in place (cross-compilation system with use of external toolschain) but the last step (use a toolchain for arm) is missing. This is not a priority on kiwix side (sadly for BSF). I could spend a day (at most) to add it. Without it we stick with a old version of kiwix-serve with which we cannot change the topbar.
  • There is a parallel work being made on the css/js for mobile. This work is in two parts : improve how we scrap wikimedia and create the zim; and rewrite the html/css of kiwix-serve to provide better responsive design. So we will rewrite the toolbar code on the kiwix side. And more than just the toolbar, we will probably update how kiwix-serve serves it.

For all of this, I think it is preferable to wait a bit for more improvement on kiwix side.
I've just open a bug on kiwix-tools for this need (kiwix/kiwix-tools#17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants