Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reuse pre-commit hook and python 3.9+ compatiblity #3

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

183amir
Copy link
Collaborator

@183amir 183amir commented Jul 9, 2024


📚 Documentation preview 📚: https://gridtk--3.org.readthedocs.build/en/3/

Copy link

github-actions bot commented Jul 9, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/gridtk
  __main__.py
  cli.py 34-41
  manager.py
  models.py
  tools.py
Project Total  

This report was generated by python-coverage-comment-action

To make the installation easier, drop clapper dependency and test against python 3.9
Also point to stable docs.
Copy link
Contributor

@Yannick-Dayer Yannick-Dayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼
I forgot about the SPDX headers in the last PR. They are indeed needed for reuse.

@183amir 183amir merged commit 432e4a3 into main Jul 9, 2024
7 checks passed
@183amir 183amir deleted the prepare-release branch July 10, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants