Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Update terms #20

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Update terms #20

merged 4 commits into from
Jul 10, 2023

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented Jul 8, 2023

builds on #19

Removes merkle specific terms, introduces generic terms

: A Merkle tree algorithm specifies how to construct the tree and how to compute its root.

Leaf Payload and Extra Data:
Verifiable Data Structure:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes after #19 start here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just approved the 'update introduction' PR separately. Might we abandon that and just squash this one once approved?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging subsequently seems fine to me.

@OR13 OR13 mentioned this pull request Jul 8, 2023
Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More generic is good, although we should have a worked example with Merkle trees

: A Merkle tree algorithm specifies how to construct the tree and how to compute its root.

Leaf Payload and Extra Data:
Verifiable Data Structure:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just approved the 'update introduction' PR separately. Might we abandon that and just squash this one once approved?

Copy link
Member

@henkbirkholz henkbirkholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subsequently to #19

@OR13 OR13 merged commit 090f8a6 into main Jul 10, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants