Skip to content
This repository has been archived by the owner on Sep 9, 2023. It is now read-only.

Update generic structures #22

Merged
merged 13 commits into from
Jul 10, 2023
Merged

Update generic structures #22

merged 13 commits into from
Jul 10, 2023

Conversation

OR13
Copy link
Collaborator

@OR13 OR13 commented Jul 8, 2023

This PR build on #20 and attempts to clarify what is generic vc what is specific to RFC9162 encodings


Inclusion Proof:
# Verifiable Data Structures in CBOR {#sec-generic-verifiable-data-structures}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the beginning of changes after #20

Substantial reordering an rewording follows...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've separately approved #19 and #20 in other PRs.Starting review from this point

Copy link
Contributor

@JAG-UK JAG-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly improves on the earlier version, I like the generality it allows for.
A couple of larger questions in here amongst the suggestions


Inclusion Proof:
# Verifiable Data Structures in CBOR {#sec-generic-verifiable-data-structures}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've separately approved #19 and #20 in other PRs.Starting review from this point

draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved

In a signed inclusion proof, the previous merkle tree root, maps to tree-size-1, and is a detached payload.

Other specification's refer to signed inclusion proofs as "receipts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is interesting. I've been struggling with the suggested need for signing inclusion proofs - in large scale native MT systems (like Ethereum) the proof stands alone (given a published root) and signatures are pointless.

Are we saying here that actually 'signed inclusion proof' means 'a signed payload which includes a bunch of things including a stand-alone inclusion proof and some extra more semantically meaningful info about what the proof is for'? i.e. a complete SCITT sig?

Copy link
Collaborator Author

@OR13 OR13 Jul 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(in the case of merkle trees) a signed inclusion proof is a signature over a merkle root, with the merkle audit path and other proof data in the unprotected header... such as that any party holding a leaf can recompute the root, and check the signature.

This allows parties to avoid storing or accessing a large shared database, such as a blockchain.

Which is also valuable to blockchain based approaches that want to be trusted by parties that won't verify the chain.... for example, a vendor might issued signed inclusion proofs, and then other vendors can trust the transparency service vendor without running all their backend, etc...

draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
draft-steele-cose-merkle-tree-proofs.md Outdated Show resolved Hide resolved
@henkbirkholz henkbirkholz merged commit 1738335 into main Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants